From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 103725 invoked by alias); 30 Jun 2015 13:23:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 103709 invoked by uid 89); 30 Jun 2015 13:23:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 30 Jun 2015 13:23:07 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id CBC3A8EA3A; Tue, 30 Jun 2015 13:23:05 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t5UDN41Z017503; Tue, 30 Jun 2015 09:23:05 -0400 Message-ID: <55929838.5030703@redhat.com> Date: Tue, 30 Jun 2015 13:23:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Patrick Palka CC: "gdb-patches@sourceware.org" Subject: Re: [PATCH 3/3] Replace TUI's select_frame hook (PR tui/13378) References: <1435372525-1374-3-git-send-email-patrick@parcs.ath.cx> <1435373402-5164-1-git-send-email-patrick@parcs.ath.cx> <5592622D.40305@redhat.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-06/txt/msg00633.txt.bz2 On 06/30/2015 01:16 PM, Patrick Palka wrote: >>> And as a result of this change and of the previous change to >>> tui_show_frame_info, the TUI is much more disciplined about updating the >>> screen, and so the flicker as described in the PR is totally gone. >> >> I think we should sort out patch 3 before patch 2. AFAICS, the >> important one is this one, right? > > This one is more important, but by itself it causes source/asm-window > scrolling to be reset after each command (due to the before_prompt > observer) even if the frame information hasn't been changed in the > meantime. Other than that they are mostly unrelated. OK, I see. I think I missed that because it only happens if you scroll enough to make the highlighted source line _not_ visible. Just scrolling a bit and entering a command is not enough to trigger it. Thanks, Pedro Alves