From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-123895-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 45506 invoked by alias); 30 Jun 2015 12:56:50 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 45497 invoked by uid 89); 30 Jun 2015 12:56:50 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 30 Jun 2015 12:56:49 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	by mx1.redhat.com (Postfix) with ESMTPS id 9ADA7A10CA;	Tue, 30 Jun 2015 12:56:48 +0000 (UTC)
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t5UCulVs026065;	Tue, 30 Jun 2015 08:56:47 -0400
Message-ID: <5592920E.4080402@redhat.com>
Date: Tue, 30 Jun 2015 12:56:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: Markus Metzger <markus.t.metzger@intel.com>
CC: gdb-patches@sourceware.org
Subject: Re: [PATCH 3/5] btrace, linux: use data_size and data_offset
References: <1435047418-21611-1-git-send-email-markus.t.metzger@intel.com> <1435047418-21611-4-git-send-email-markus.t.metzger@intel.com>
In-Reply-To: <1435047418-21611-4-git-send-email-markus.t.metzger@intel.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-SW-Source: 2015-06/txt/msg00630.txt.bz2

On 06/23/2015 09:16 AM, Markus Metzger wrote:

OK with,


> +#if defined(PERF_ATTR_SIZE_VER5)
> +  if (offsetof(struct perf_event_mmap_page, data_size) <= header->size)

'offsetof ('

and 'defined (', while at it.

> +    {
> +      data_offset = header->data_offset;
> +      data_size = header->data_size;
> +    }
> +#endif /* defined(PERF_ATTR_SIZE_VER5) */
> +


Thanks,
Pedro Alves