From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 67190 invoked by alias); 30 Jun 2015 09:57:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 66775 invoked by uid 89); 30 Jun 2015 09:57:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 30 Jun 2015 09:57:16 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 5BED42C76EA; Tue, 30 Jun 2015 09:57:15 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t5U9vDGW029518; Tue, 30 Jun 2015 05:57:14 -0400 Message-ID: <559267F9.6000307@redhat.com> Date: Tue, 30 Jun 2015 09:57:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Wei-cheng Wang , uweigand@de.ibm.com, gdb-patches@sourceware.org Subject: Re: [PATCH 1/5 v4] Remove tracepoint_action ops. References: <1435422102-39438-1-git-send-email-cole945@gmail.com> In-Reply-To: <1435422102-39438-1-git-send-email-cole945@gmail.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-06/txt/msg00623.txt.bz2 On 06/27/2015 05:21 PM, Wei-cheng Wang wrote: > This patch removes 'ops' in tracepoint, and uses helper functions to > call action handler instead. > > The object layout of tracepoint_action may differ in gdbserver and > inferior depend on the alignment rule of target ABI, so gdbserver cannot > simply copy the object from its memory to inferior memory. > > For example, > > struct collect_memory_action > { > struct tracepoint_action base; > { > #ifndef IN_PROCESS_AGENT > const struct tracepoint_action_ops *ops; > #if > - char type; > | } > | ULONGEST addr; > | ULONGEST len; > - int32_t basereg; > }; > > and on PowerPC, > > Wihtout ops with ops > 0 1 2 3 0 1 2 3 > 0 |type| PADDING... 0 |ops-------------| > 4 ................. 4 |type|PADDING....| > 8 |addr------------ 8 |addr------------- > c ----------------| c -----------------| > 10 |len------------- 10 |len-------------- > 14 ----------------| 14 -----------------| > 18 |basereg--------| 18 |basereg---------| > > so we cannot directly copy the object. > > In this patch, 'ops' is removed in order to make the objects identical. > > gdbserver/ChangeLog > > 2015-06-27 Wei-cheng Wang > > * tracepoint.c (struct tracepoint_action): Remove ops. > (m_tracepoint_action_download, r_tracepoint_action_download, > x_tracepoint_action_download, l_tracepoint_action_download): Adjust > size and offset accordingly. > (m_tracepoint_action_ops, r_tracepoint_action_ops, > x_tracepoint_action_ops, l_tracepoint_action_ops): Delete > (tracepoint_action_send, tracepoint_action_download): New functions. > Helpers for tracetion action handlers. > (add_tracepoint_action): Remove setup actions ops. > (download_tracepoint_1, tracepoint_send_agent): Call helper functions. > --- FAOD, this looks fine to me. Thanks, -- Pedro Alves