From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 63898 invoked by alias); 30 Jun 2015 08:36:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 63888 invoked by uid 89); 30 Jun 2015 08:36:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 30 Jun 2015 08:36:06 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 1D71CB59B0; Tue, 30 Jun 2015 08:36:05 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t5U8a3bM026264; Tue, 30 Jun 2015 04:36:04 -0400 Message-ID: <559254F3.4040209@redhat.com> Date: Tue, 30 Jun 2015 08:36:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Patrick Palka , gdb-patches@sourceware.org Subject: Re: [PATCH 1/3] Correctly initialize the TUI locator window References: <1435372525-1374-1-git-send-email-patrick@parcs.ath.cx> In-Reply-To: <1435372525-1374-1-git-send-email-patrick@parcs.ath.cx> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-06/txt/msg00620.txt.bz2 On 06/27/2015 03:35 AM, Patrick Palka wrote: > The call to tui_alloc_content in tui_set_locator_info passes > locator->type as the type of the window whose content is being > allocated. This may seem correct but it's actually not because when > this code path actually get executed locator->type has not yet been to > set LOCATOR_WIN so it defaults to 0 i.e. SRC_WIN. Thus we allocate the > content of the locator window as if it was the source window. This > oversight turns out not to be a big deal in practice but the patch that > follows depends on the locator's proc_name and full_name arrays to be > initialized to the empty string which is done by tui_alloc_content if > we pass to it LOCATOR_WIN. > > This patch fixes this bug by explicitly passing LOCATOR_WIN to > tui_alloc_content. OK. Thanks, Pedro Alves