Re: [PATCH v2 3/5] Add gdb::string_view

[Pedro Alves <palves@redhat.com>]

On 04/06/2018 09:37 PM, Simon Marchi wrote:

> Ah, from the name I thought that experimental version contained the code implementing future standards, before they were official... so I'll start from scratch using the version from experimental, does that sounds good?

It does.  However, there may have been other enhancements, small API changes, and
bugfixes to string_view when it was merged to the standard proper (and subsequent
DRs), so I'd still recommend perusing the diff a bit.  Though if the tests still
pass, it'll likely the differences won't matter much.

>>>    template<>
>>>      struct hash<string_view>
>>> -    : public __hash_base<size_t, string_view>
>>> +    : public std::__hash_base<size_t, string_view>
>>
>> This looks suspiciously like using an internal implementation
>> detail of libstdc++.  Where is std::__hash_base defined?
>> Does this compile with clang + libc++ ?
> 
> Hmm indeed.  Well, it looks like building with clang + libstdcxx fails.  I'll make sure to test both of these combinations in the next iteration.

Thanks.

Pedro Alves