From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 71784 invoked by alias); 24 Jun 2015 13:39:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 71769 invoked by uid 89); 24 Jun 2015 13:39:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 24 Jun 2015 13:39:39 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 56AD319CB9C; Wed, 24 Jun 2015 13:39:38 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t5ODdaVU002034; Wed, 24 Jun 2015 09:39:37 -0400 Message-ID: <558AB318.2060003@redhat.com> Date: Wed, 24 Jun 2015 13:39:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] Add aarch64-linux in supports_get_siginfo_type References: <1434971017-22494-1-git-send-email-yao.qi@linaro.org> <1434971017-22494-2-git-send-email-yao.qi@linaro.org> <558A8A4B.5090103@redhat.com> <86ioadqlmd.fsf@gmail.com> In-Reply-To: <86ioadqlmd.fsf@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-06/txt/msg00525.txt.bz2 On 06/24/2015 02:30 PM, Yao Qi wrote: >> >> though at the pace this is taking, it'd probably be better to register >> linux_get_siginfo_type as default for all Linux archs (in >> linux-tdep.c:linux_init_abi), >> and have archs whoch kernel/ABI uses the non-generic siginfo layout install a >> custom get_siginfo_type version. The supports_get_siginfo_type >> testsuite function >> would then return true for [istarget "*-*-linux*"]. The testsuite >> would then help >> show which archs would those be. > > Change like this may cause some fails for some linux targets which need > their custom get_siginfo_type implementations. Right, that's how I was thinking the tests would help. As is currently, arch maintainers miss that the feature even exists. > Here is a patch below, > I rerun siginfo-obj.exp and siginfo-thread.exp on aarch64/arm/x86_64 linux. Thanks. > From 476653a2990b4ebfac806b0da6ffa24b5672ece9 Mon Sep 17 00:00:00 2001 > From: Yao Qi > Date: Fri, 19 Jun 2015 14:50:33 +0100 > Subject: [PATCH] Call set_gdbarch_get_siginfo_type in linux_init_abi > > linux_get_siginfo_type is installed to many linux gdbarch. This patch > is to move this to a common area linux-tdep.c:linux_init_abi, so that > linux_get_siginfo_type is installed to every linux gdbarch. If some > linux gdbarch needs its own version, please override it in > $ARCH_linux_init_abi. In the testsuite, we enable siginfo related > tests for all linux targets. (Or if you need a quick fix, set it to NULL in that particular arch's gdbarch init function.) Looks good to me. Thanks for doing this. -- Pedro Alves