From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11668 invoked by alias); 24 Jun 2015 10:45:36 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 11653 invoked by uid 89); 24 Jun 2015 10:45:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 24 Jun 2015 10:45:34 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id A32032C7716; Wed, 24 Jun 2015 10:45:33 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t5OAjWnK018507; Wed, 24 Jun 2015 06:45:32 -0400 Message-ID: <558A8A4B.5090103@redhat.com> Date: Wed, 24 Jun 2015 10:45:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Yao Qi , gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] Add aarch64-linux in supports_get_siginfo_type References: <1434971017-22494-1-git-send-email-yao.qi@linaro.org> <1434971017-22494-2-git-send-email-yao.qi@linaro.org> In-Reply-To: <1434971017-22494-2-git-send-email-yao.qi@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-06/txt/msg00517.txt.bz2 On 06/22/2015 12:03 PM, Yao Qi wrote: > gdbarch method get_siginfo_type is implemented on aaarch64-linux, so > supports_get_siginfo_type should return 1 on aaarch64-linux. typo: aaarch64. (Patch looks obvious to me.) I note that a few other archs are also missing here: aarch64-linux-tdep.c: set_gdbarch_get_siginfo_type (gdbarch, linux_get_siginfo_type); amd64-linux-tdep.c: set_gdbarch_get_siginfo_type (gdbarch, linux_get_siginfo_type); arm-linux-tdep.c: set_gdbarch_get_siginfo_type (gdbarch, linux_get_siginfo_type); i386-linux-tdep.c: set_gdbarch_get_siginfo_type (gdbarch, linux_get_siginfo_type); m68klinux-tdep.c: set_gdbarch_get_siginfo_type (gdbarch, linux_get_siginfo_type); ppc-linux-tdep.c: set_gdbarch_get_siginfo_type (gdbarch, linux_get_siginfo_type); s390-linux-tdep.c: set_gdbarch_get_siginfo_type (gdbarch, linux_get_siginfo_type); tilegx-linux-tdep.c: set_gdbarch_get_siginfo_type (gdbarch, linux_get_siginfo_type); though at the pace this is taking, it'd probably be better to register linux_get_siginfo_type as default for all Linux archs (in linux-tdep.c:linux_init_abi), and have archs whoch kernel/ABI uses the non-generic siginfo layout install a custom get_siginfo_type version. The supports_get_siginfo_type testsuite function would then return true for [istarget "*-*-linux*"]. The testsuite would then help show which archs would those be. Thanks, Pedro Alves