From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 90617 invoked by alias); 22 Jun 2015 14:28:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 84388 invoked by uid 89); 22 Jun 2015 14:27:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 X-HELO: homiemail-a46.g.dreamhost.com Received: from sub5.mail.dreamhost.com (HELO homiemail-a46.g.dreamhost.com) (208.113.200.129) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 22 Jun 2015 14:27:44 +0000 Received: from homiemail-a46.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a46.g.dreamhost.com (Postfix) with ESMTP id 270813E405C for ; Mon, 22 Jun 2015 07:27:43 -0700 (PDT) Received: from vm-fedora21.eagercon.com (c-24-7-16-38.hsd1.ca.comcast.net [24.7.16.38]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: eager@eagerm.com) by homiemail-a46.g.dreamhost.com (Postfix) with ESMTPSA id 12A943E405B for ; Mon, 22 Jun 2015 07:27:43 -0700 (PDT) Message-ID: <55881B5E.3020808@eagerm.com> Date: Mon, 22 Jun 2015 14:28:00 -0000 From: Michael Eager User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb: microblaze: delete useless stubs References: <1434910383-18403-1-git-send-email-vapier@gentoo.org> <5587124B.5010504@eagerm.com> <20150622045610.GE17734@vapier> In-Reply-To: <20150622045610.GE17734@vapier> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-06/txt/msg00443.txt.bz2 On 06/21/2015 09:56 PM, Mike Frysinger wrote: > On 21 Jun 2015 12:36, Michael Eager wrote: >> On 06/21/2015 11:13 AM, Mike Frysinger wrote: >>> These don't accomplish anything the common core doesn't already, so >>> punt them as they purely waste code. >>> >>> 2015-06-21 Mike Frysinger >>> >>> * microblaze-tdep.c (microblaze_push_dummy_code): Delete. >>> (microblaze_push_dummy_call): Likewise. >>> (microblaze_gdbarch_init): Delete calls to set_gdbarch_push_dummy_code >>> and set_gdbarch_push_dummy_call. >> >> Does the common code issue an error if someone tries >> to call a target function? > > yes > > gdb/infcall.c: > struct value * > call_function_by_hand_dummy (struct value *function, > ... > if (!gdbarch_push_dummy_call_p (gdbarch)) > error (_("This target does not support function calls.")); > > $ ./gdb ... > (gdb) p foo(1) > This target does not support function calls. > -mike Go ahead and commit. -- Michael Eager eager@eagercon.com 1960 Park Blvd., Palo Alto, CA 94306 650-325-8077