From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 107365 invoked by alias); 12 Oct 2019 23:09:58 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 106758 invoked by uid 89); 12 Oct 2019 23:09:57 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy=H*r:112, UD:ca X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 12 Oct 2019 23:09:56 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id x9CN9mW9016731 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sat, 12 Oct 2019 19:09:53 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca x9CN9mW9016731 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1570921794; bh=XVKDpC50HsIRurusMkk4uM2MRC4gq3Qvv7HmKgnEMfg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=pWnQ6fuA2aq2f1NNJFCwWoG1QeIH0xz6nIPZAdsU70qQU+Xua4bxWQyMsWRPXRNxU bnhAQ8jMyc3qa94Z4jw73NijPg6yKy8+m549b0JOu0FKFUuVVOuNCYuTek3ru3L+Ug uUZFuSzu1U6/442moEGGC7D6L6XGpEVU2nuzpGIM= Received: by simark.ca (Postfix, from userid 112) id 594CF1E79E; Sat, 12 Oct 2019 19:09:48 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 2E3391E4A5; Sat, 12 Oct 2019 19:09:47 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Sat, 12 Oct 2019 23:09:00 -0000 From: Simon Marchi To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH][gdb/testsuite] Add KFAIL for missing support of reverse-debugging xsave In-Reply-To: <20190927151128.GA29080@delia> References: <20190927151128.GA29080@delia> Message-ID: <558367f403dfa6290ed40b06382b45dc@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.10 X-IsSubscribed: yes X-SW-Source: 2019-10/txt/msg00312.txt.bz2 On 2019-09-27 11:11, Tom de Vries wrote: > Hi, > > Normally the gdb.reverse/*.exp test-cases pass on my system (apart from > the > record/23188 KFAIL for gdb.reverse/step-precsave.exp). But when > specifying > GLIBC_TUNABLES=glibc.tune.hwcaps=-XSAVEC_Usable to force glibc to use > _dl_runtime_resolve_xsave instead of _dl_runtime_resolve_xsavec, we run > into > 1054 FAILs like this: > ... > (gdb) PASS: gdb.reverse/sigall-reverse.exp: b gen_HUP > continue^M > Continuing.^M > Process record does not support instruction 0xfae64 at address \ > 0x7ffff7ded958.^M > Process record: failed to record execution log.^M > ^M > Program stopped.^M > 0x00007ffff7ded958 in _dl_runtime_resolve_xsave () from \ > /lib64/ld-linux-x86-64.so.2^M > (gdb) FAIL: gdb.reverse/sigall-reverse.exp: get signal ABRT > ... > > The problem is that the xsave instruction is not supported in > reverse-debugging (PR record/25038). > > Add KFAILs for this PR. > > Tested on x86_64-linux. > > OK for trunk? Hi Tom, That looks good to me in general. Just one note here: > @@ -289,8 +295,12 @@ set sig_supported 1 > set thissig "ABRT" > > # test signal handling > +set record_instruction_kfail 0 > foreach sig [lrange $signals 1 end] { > test_one_sig $sig > + if { $record_instruction_kfail } { > + return -1 > + } It seems like record_instruction_kfail is never set in this file, sigall-precsave.exp, I suppose it should? Simon