From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-123659-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 111522 invoked by alias); 18 Jun 2015 17:14:08 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 111509 invoked by uid 89); 18 Jun 2015 17:14:08 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2
X-HELO: usevmg20.ericsson.net
Received: from usevmg20.ericsson.net (HELO usevmg20.ericsson.net) (198.24.6.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 18 Jun 2015 17:14:07 +0000
Received: from EUSAAHC001.ericsson.se (Unknown_Domain [147.117.188.75])	by usevmg20.ericsson.net (Symantec Mail Security) with SMTP id 4F.41.32689.232A2855; Thu, 18 Jun 2015 12:49:23 +0200 (CEST)
Received: from [142.133.110.144] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.77) with Microsoft SMTP Server id 14.3.210.2; Thu, 18 Jun 2015 13:14:04 -0400
Message-ID: <5582FC5C.50907@ericsson.com>
Date: Thu, 18 Jun 2015 17:14:00 -0000
From: Simon Marchi <simon.marchi@ericsson.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Pedro Alves <palves@redhat.com>, <gdb-patches@sourceware.org>
Subject: Re: [PATCH v2 6/7] remote: consider addressable unit size when reading/writing memory
References: <1429127258-1033-1-git-send-email-simon.marchi@ericsson.com> <1429127258-1033-7-git-send-email-simon.marchi@ericsson.com> <555E1A50.7020007@redhat.com> <557F274A.3060908@ericsson.com> <55816041.8080001@redhat.com>
In-Reply-To: <55816041.8080001@redhat.com>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
X-SW-Source: 2015-06/txt/msg00394.txt.bz2

On 15-06-17 07:55 AM, Pedro Alves wrote:
> On 06/15/2015 08:28 PM, Simon Marchi wrote:
> 
>>>>    -> $m1000,8#??
>>>>    <- aaaabbbbccccdddd
>>>>
>>>>    -> $M1000,6:eeeeffffeeee#??
>>>>    <- OK
>>>>
>>>>    -> $m1000,8#??
>>>>    <- eeeeffffeeeedddd
>>>>
>>
>> Ok, I put the example in the comment of remote_write_bytes_aux and added
>> a reference to it in remote_read_bytes_1. Do you have a more suitable place
>> in mind where to put it?
> 
> Nope, that sounds good.
> 
>> Thanks for the review. Here's what's new:
>>
>> * needs_escaping: Added newline and comment.
>> * remote_escape_output: Add missing space.
>> * remote_write_bytes_aux: Send length in addressable units, update comment with example gdb/stub exchange.
>> * remote_read_bytes_1: Same, and update function comment (add UNIT_SIZE).
> 
> Looks good to me.
> 
> Thanks,
> Pedro Alves

Thanks, pushed.