From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-123649-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 116576 invoked by alias); 18 Jun 2015 11:05:35 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 116553 invoked by uid 89); 18 Jun 2015 11:05:34 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.2
X-HELO: out5-smtp.messagingengine.com
Received: from out5-smtp.messagingengine.com (HELO out5-smtp.messagingengine.com) (66.111.4.29) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 18 Jun 2015 11:05:32 +0000
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44])	by mailout.nyi.internal (Postfix) with ESMTP id E3924208B6	for <gdb-patches@sourceware.org>; Thu, 18 Jun 2015 07:05:30 -0400 (EDT)
Received: from frontend1 ([10.202.2.160])  by compute4.internal (MEProxy); Thu, 18 Jun 2015 07:05:30 -0400
Received: from [192.168.1.102] (unknown [86.141.128.210])	by mail.messagingengine.com (Postfix) with ESMTPA id 5DCA2C00025;	Thu, 18 Jun 2015 07:05:30 -0400 (EDT)
Message-ID: <5582A5F3.1060602@dronecode.org.uk>
Date: Thu, 18 Jun 2015 11:05:00 -0000
From: Jon TURNEY <jon.turney@dronecode.org.uk>
User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Yao Qi <qiyaoltc@gmail.com>
CC: binutils@sourceware.org, gdb-patches@sourceware.org
Subject: Re: [PATCH] Allow gdb to find debug symbols file by build-id for PE file format also
References: <20150609193638.GM2855@adacore.com>	<1433946324-7600-1-git-send-email-jon.turney@dronecode.org.uk> <86k2v2s4f4.fsf@gmail.com>
In-Reply-To: <86k2v2s4f4.fsf@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2015-06/txt/msg00384.txt.bz2

On 17/06/2015 17:09, Yao Qi wrote:
> Jon Turney writes:
>
>> +	return $data
>>       }
>> -    set fi [open $tmp]
>> -    fconfigure $fi -translation binary
>> -    # Skip the NOTE header.
>> -    read $fi 16
>> -    set data [read $fi]
>> -    close $fi
>> -    file delete $tmp
>> -    if ![string compare $data ""] then {
>> -	return ""
>> +    else
>> +    {
>
> braces and "else" are put in the different lines.  It causes the tcl
> error,
>
> Running ../../../binutils-gdb/gdb/testsuite/gdb.base/break-interp.exp ...
> ERROR: (DejaGnu) proc "else" does not exist.
> The error code is NONE
> The info on the error is:
> invalid command name "else"
>      while executing
> "::tcl_unknown else"
>      ("uplevel" body line 1)
>      invoked from within
> "uplevel 1 ::tcl_unknown $args"
>
> Patch below fixes this error.  I'll push it in.

Thanks.