From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 84807 invoked by alias); 17 Jun 2015 20:16:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 84795 invoked by uid 89); 17 Jun 2015 20:16:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 17 Jun 2015 20:16:46 +0000 Received: from svr-orw-fem-04.mgc.mentorg.com ([147.34.97.41]) by relay1.mentorg.com with esmtp id 1Z5JlK-0006mi-GD from Luis_Gustavo@mentor.com ; Wed, 17 Jun 2015 13:16:42 -0700 Received: from [134.86.101.215] (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.3.224.2; Wed, 17 Jun 2015 13:16:42 -0700 Message-ID: <5581D5A9.3070706@codesourcery.com> Date: Wed, 17 Jun 2015 20:16:00 -0000 From: Luis Machado Reply-To: Luis Machado User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Pedro Alves , Subject: Re: [PATCH] Fix problems with finishing a dummy function call on simulators. References: <1433862056-18237-1-git-send-email-lgustavo@codesourcery.com> <55772797.802@redhat.com> <55805F52.20805@codesourcery.com> <55816AD5.6020605@redhat.com> <55817569.7060704@codesourcery.com> <5581798B.5080207@redhat.com> In-Reply-To: <5581798B.5080207@redhat.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-06/txt/msg00376.txt.bz2 On 06/17/2015 10:43 AM, Pedro Alves wrote: > On 06/17/2015 02:26 PM, Luis Machado wrote: >> On 06/17/2015 09:40 AM, Pedro Alves wrote: > >>> Yep. Close, but also remove the bp_call_dummy check in >>> bp_loc_is_permanent, and merge in its comment, like ... >>> >> >> Fixed now. > > Looks good now. Thanks. > >> The attached updated patch also removes this dead function. I can commit >> it as a separate patch if you're not removing it yourself. > > Nah, I was hoping you'd remove it. :-) Please also remove the > make_breakpoint_permanent declaration from breakpoint.h though. Thanks. I've pushed this in now and pushed the removal with a different patch.