From: Keith Seitz <keiths@redhat.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFC] Revisit PR 16253 ("Attempt to use a type name...")
Date: Wed, 17 Jun 2015 15:50:00 -0000 [thread overview]
Message-ID: <5581972B.3020200@redhat.com> (raw)
In-Reply-To: <20150617123357.GA12138@host1.jankratochvil.net>
On 06/17/2015 05:33 AM, Jan Kratochvil wrote:
> On Thu, 11 Jun 2015 20:57:18 +0200, Keith Seitz wrote:
>> PR 16253
>> * block.c (block_lookup_symbol_primary): If a symbol is found
>> which does not exactly match the requested domain, keep searching
>> for an exact match. Otherwise, return the previously found "best"
>> symbol.
>
> Is there a reason why you haven't patched also block_lookup_symbol?
Two reasons:
1) I posted this RFC to raise discussion whether this was worth
pursuing. No need to expend any energy on something that has zero chance
of being accepted by maintainers.
2) More important I have not discovered/attempted to coverage test
lookup_block_symbol to trigger this bug.
I'll be attempting to do that today.
Keith
next prev parent reply other threads:[~2015-06-17 15:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-11 18:57 Keith Seitz
2015-06-16 16:29 ` Jan Kratochvil
2015-06-17 12:34 ` Jan Kratochvil
2015-06-17 15:50 ` Keith Seitz [this message]
2015-06-23 18:39 ` Keith Seitz
2015-06-23 19:53 ` Jan Kratochvil
2015-06-16 17:54 Doug Evans
2015-06-16 21:02 ` Doug Evans
2015-06-17 15:46 ` Keith Seitz
2015-06-24 16:54 Doug Evans
2015-06-24 23:02 Doug Evans
2015-06-25 18:26 ` Keith Seitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5581972B.3020200@redhat.com \
--to=keiths@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox