From: Pedro Alves <palves@redhat.com>
To: Luis Machado <lgustavo@codesourcery.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix problems with finishing a dummy function call on simulators.
Date: Wed, 17 Jun 2015 13:43:00 -0000 [thread overview]
Message-ID: <5581798B.5080207@redhat.com> (raw)
In-Reply-To: <55817569.7060704@codesourcery.com>
On 06/17/2015 02:26 PM, Luis Machado wrote:
> On 06/17/2015 09:40 AM, Pedro Alves wrote:
>> Yep. Close, but also remove the bp_call_dummy check in
>> bp_loc_is_permanent, and merge in its comment, like ...
>>
>
> Fixed now.
Looks good now. Thanks.
> The attached updated patch also removes this dead function. I can commit
> it as a separate patch if you're not removing it yourself.
Nah, I was hoping you'd remove it. :-) Please also remove the
make_breakpoint_permanent declaration from breakpoint.h though.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2015-06-17 13:43 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-09 15:01 Luis Machado
2015-06-09 17:51 ` Pedro Alves
2015-06-09 18:10 ` Luis Machado
2015-06-09 18:13 ` Pedro Alves
2015-06-09 18:22 ` Luis Machado
2015-06-09 18:34 ` Luis Machado
2015-06-16 17:39 ` Luis Machado
2015-06-17 12:41 ` Pedro Alves
2015-06-17 13:26 ` Luis Machado
2015-06-17 13:43 ` Pedro Alves [this message]
2015-06-17 20:16 ` Luis Machado
2015-07-06 15:06 ` Pedro Alves
2015-07-06 15:33 ` Luis Machado
2015-07-06 16:15 ` Pedro Alves
2015-07-06 16:18 ` Luis Machado
2015-07-06 18:34 ` Luis Machado
2015-07-06 19:07 ` Pedro Alves
2015-07-06 19:11 ` Luis Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5581798B.5080207@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=lgustavo@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox