From: Pedro Alves <palves@redhat.com>
To: Patrick Palka <patrick@parcs.ath.cx>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Don't truncate the history file when history size is unlimited
Date: Wed, 17 Jun 2015 12:46:00 -0000 [thread overview]
Message-ID: <55816C34.3060908@redhat.com> (raw)
In-Reply-To: <1434466413-28892-1-git-send-email-patrick@parcs.ath.cx>
On 06/16/2015 03:53 PM, Patrick Palka wrote:
> + # We have to start then exit GDB twice: the first time to test the creation
> + # of the initial history file, and the second time to test appending to it.
> + # In either case the initial "print 1" command should persist through the
> + # history file.
> + with_test_prefix "truncation" {
> + gdb_exit
> + gdb_start
> + gdb_test "print 1"
> +
> + gdb_exit
> + gdb_start
> + gdb_test "server show commands" " . print 1.*"
> +
> + gdb_exit
> + gdb_start
> + gdb_test "server show commands" " . print 1.*"
These two "show commands" tests have the same output message. The
patch is OK with that fixed.
Thanks for following through with the test.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2015-06-17 12:46 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-09 19:28 Patrick Palka
2015-06-15 15:25 ` Pedro Alves
2015-06-15 16:01 ` Patrick Palka
2015-06-15 16:18 ` Pedro Alves
2015-06-16 14:53 ` Patrick Palka
2015-06-16 15:00 ` Patrick Palka
2015-06-17 13:14 ` Pedro Alves
2015-06-17 12:46 ` Pedro Alves [this message]
2015-07-23 18:42 ` Racy failures on gdb.base/gdbinit-history.exp (native-extended-gdbserver/-m64) (was: Re: [PATCH] Don't truncate the history file when history size is unlimited) Sergio Durigan Junior
2015-07-23 19:33 ` Patrick Palka
2015-07-24 14:03 ` Patrick Palka
2015-07-24 14:16 ` Patrick Palka
2015-08-13 15:18 ` Patrick Palka
2015-08-13 22:28 ` Racy failures on gdb.base/gdbinit-history.exp (native-extended-gdbserver/-m64) Sergio Durigan Junior
2015-08-13 23:26 ` Pedro Alves
2015-08-14 0:46 ` Sergio Durigan Junior
2015-08-17 13:16 ` Patrick Palka
2015-08-17 13:28 ` Patrick Palka
2015-08-17 14:03 ` Pedro Alves
2015-08-17 20:10 ` Patrick Palka
2015-08-17 23:29 ` Patrick Palka
2015-09-10 13:44 ` Pedro Alves
2015-09-10 15:30 ` Sergio Durigan Junior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55816C34.3060908@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=patrick@parcs.ath.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox