From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 120115 invoked by alias); 17 Jun 2015 11:55:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 120049 invoked by uid 89); 17 Jun 2015 11:55:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 17 Jun 2015 11:55:48 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 12AB0C9B30; Wed, 17 Jun 2015 11:55:47 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t5HBtjNJ024951; Wed, 17 Jun 2015 07:55:46 -0400 Message-ID: <55816041.8080001@redhat.com> Date: Wed, 17 Jun 2015 11:55:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH v2 6/7] remote: consider addressable unit size when reading/writing memory References: <1429127258-1033-1-git-send-email-simon.marchi@ericsson.com> <1429127258-1033-7-git-send-email-simon.marchi@ericsson.com> <555E1A50.7020007@redhat.com> <557F274A.3060908@ericsson.com> In-Reply-To: <557F274A.3060908@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-06/txt/msg00357.txt.bz2 On 06/15/2015 08:28 PM, Simon Marchi wrote: >>> -> $m1000,8#?? >>> <- aaaabbbbccccdddd >>> >>> -> $M1000,6:eeeeffffeeee#?? >>> <- OK >>> >>> -> $m1000,8#?? >>> <- eeeeffffeeeedddd >>> > > Ok, I put the example in the comment of remote_write_bytes_aux and added > a reference to it in remote_read_bytes_1. Do you have a more suitable place > in mind where to put it? Nope, that sounds good. > Thanks for the review. Here's what's new: > > * needs_escaping: Added newline and comment. > * remote_escape_output: Add missing space. > * remote_write_bytes_aux: Send length in addressable units, update comment with example gdb/stub exchange. > * remote_read_bytes_1: Same, and update function comment (add UNIT_SIZE). Looks good to me. Thanks, Pedro Alves