From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 110483 invoked by alias); 15 Jun 2015 15:25:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 110405 invoked by uid 89); 15 Jun 2015 15:25:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 15 Jun 2015 15:25:54 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 5848A3589F0; Mon, 15 Jun 2015 15:25:52 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t5FFPo3i004200; Mon, 15 Jun 2015 11:25:51 -0400 Message-ID: <557EEE7E.90802@redhat.com> Date: Mon, 15 Jun 2015 15:25:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Patrick Palka , gdb-patches@sourceware.org Subject: Re: [PATCH] Don't truncate the history file when history size is unlimited References: <1433878062-23560-1-git-send-email-patrick@parcs.ath.cx> In-Reply-To: <1433878062-23560-1-git-send-email-patrick@parcs.ath.cx> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-06/txt/msg00316.txt.bz2 On 06/09/2015 08:27 PM, Patrick Palka wrote: > We still do not handle "set history size unlimited" correctly. In > particular, after writing to the history file, we truncate the history > even if it is unlimited. Whoops. > > This patch makes sure that we do not call history_truncate_file() if the > history is not stifled (i.e. if it's unlimited). This bug causes the > history file to be truncated to zero on exit when one has "set history > size unlimited" in their gdbinit file. Although this code exists in GDB > 7.8 it is masked by a pre-existing bug that's been only fixed in GDB 7.9 > (PR gdb/17820). > > I tried to make a test to check that the history does not get truncated > on exit when the history size is unlimited, but I could not get the test > to work properly. How so? > Also I could not figure out a good way to create a > temporary file (to act as the history file) in tcl versions earlier than > 8.6. I am not sure if it's worth the effort to add a test. Not sure I follow. Why do you need a temporary file? You can leave the file in the build/test dir. In fact, that's encouraged, to make it easier to debug the test on failures. You can instead delete a stale file from a previous run at the start of the (new) run. > (Apparently I did not test my changes to history file handling > extensively enough. Sorry..) Don't stress about it. But, it does show out that having a test would be useful. So I think it's worth the effort. The code changes look OK to me. Thanks, Pedro Alves