From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 79838 invoked by alias); 15 Jun 2015 15:14:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 79745 invoked by uid 89); 15 Jun 2015 15:14:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 X-HELO: homiemail-a68.g.dreamhost.com Received: from sub5.mail.dreamhost.com (HELO homiemail-a68.g.dreamhost.com) (208.113.200.129) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 15 Jun 2015 15:14:15 +0000 Received: from homiemail-a68.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a68.g.dreamhost.com (Postfix) with ESMTP id 8F27E40113762 for ; Mon, 15 Jun 2015 08:14:13 -0700 (PDT) Received: from vm-fedora21.eagercon.com (c-24-7-16-38.hsd1.ca.comcast.net [24.7.16.38]) (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: eager@eagerm.com) by homiemail-a68.g.dreamhost.com (Postfix) with ESMTPSA id 784D740113760 for ; Mon, 15 Jun 2015 08:14:13 -0700 (PDT) Message-ID: <557EEBC5.4080208@eagerm.com> Date: Mon, 15 Jun 2015 15:14:00 -0000 From: Michael Eager User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: Re: [PATCH] Support gzip compressed exec and core files in gdb References: <54FF77D6.7010400@eagerm.com> <5543905A.1040108@eagerm.com> <83r3r0qj5i.fsf@gnu.org> <5543F840.4040805@eagerm.com> <20150504075005.GG30924@vapier> In-Reply-To: <20150504075005.GG30924@vapier> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-06/txt/msg00315.txt.bz2 On 05/04/2015 12:50 AM, Mike Frysinger wrote: > On 01 May 2015 15:03, Michael Eager wrote: >> On 05/01/2015 10:53 AM, Eli Zaretskii wrote: >>>> Date: Fri, 01 May 2015 07:40:26 -0700 >>>> From: Michael Eager >>>> >>>> On 03/10/2015 04:01 PM, Michael Eager wrote: >>>>> Add support to automatically unzip compressed executable and core files. >>>>> Files will be uncompressed into temporary directory (/tmp or $TMPDIR) >>>>> and are deleted when GDB exits. This should be transparent to users, >>>>> except for disk space requirements. The name of the uncompressed file is >>>>> mentioned, but all references to the file in GDB messages is to the file >>>>> which the user specified. >>>> >>>> Attached is a revised patch. I discovered a logic error after refactoring >>>> the code. >>> >>> OK for the documentation parts. >>> >>>> + decomp_fd = mkstemp (template); >>> >>> Do we have mkstemp on all supported platforms? >> >> It looks like there is a version in gnulib, if not supported natively. > > libiberty limits itself to "mkstemps" since it provides a fallback for that ... > -mike > Any comment on this patch? Or approval? -- Michael Eager eager@eagercon.com 1960 Park Blvd., Palo Alto, CA 94306 650-325-8077