From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 71452 invoked by alias); 15 Jun 2015 15:09:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 71433 invoked by uid 89); 15 Jun 2015 15:09:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 15 Jun 2015 15:09:40 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 08802367290; Mon, 15 Jun 2015 15:09:39 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t5FF9bSa009999; Mon, 15 Jun 2015 11:09:38 -0400 Message-ID: <557EEAB0.5040607@redhat.com> Date: Mon, 15 Jun 2015 15:09:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Patrick Palka , gdb-patches@sourceware.org Subject: Re: [PATCH] Call target_terminal_ours() before refreshing TUI's frame info References: <1433260372-12694-1-git-send-email-patrick@parcs.ath.cx> In-Reply-To: <1433260372-12694-1-git-send-email-patrick@parcs.ath.cx> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-06/txt/msg00312.txt.bz2 On 06/02/2015 04:52 PM, Patrick Palka wrote: > In some cases tui_show_frame_info() may get called while the inferior's > terminal settings are still in effect. But when we call this function > we absolutely need to have our terminal settings in effect because the > function is responsible for redrawing TUI's windows following a change > in the selected frame or a change in the PC. If our terminal settings > are not in effect, the screen does not get redrawn properly, causing > temporary display artifacts (which can be fixed via ^L). > > This scenario happens most prominently when stepping through a program > in TUI while a watchpoint is in effect. > > Here is an example backtrace for when tui_show_frame_info() gets called > while target_terminal_is_inferior() == 1: > > #1 0x00000000004988ee in tui_selected_frame_level_changed_hook (level=0) > #2 0x0000000000617b99 in select_frame (fi=0x18c9820) > #3 0x0000000000617c3f in get_selected_frame (message=message@entry=0x0) > #4 0x00000000004ce534 in update_watchpoint (b=b@entry=0x2d9a760, > reparse=reparse@entry=0) > #5 0x00000000004d625e in insert_breakpoints () > #6 0x0000000000531cfe in keep_going (ecs=ecs@entry=0x7ffea7884ac0) > #7 0x00000000005326d7 in process_event_stop_test (ecs=ecs@entry=0x7ffea7884ac0) > #8 0x000000000053596e in handle_inferior_event_1 (ecs=0x7ffea7884ac0) > > The fix is simple: call target_terminal_ours() before calling > tui_show_frame_info() in TUI's frame-changed hook, making sure to > restore the original terminal settings afterwards. > > gdb/ChangeLog: > > * tui/tui-hooks.c (tui_selected_frame_level_changed_hook): Call > target_terminal_ours() before calling tui_show_frame_info(), and > restore the original terminal settings afterwards. OK, though please try/use target_terminal_ours_for_output instead. I think we should get rid of this hook entirely, and refresh the window at some higher level point. Refreshing the window for each internal stop and/or selected frame save/restore results in lots of pointless flicker... I'm sure you've noticed. :-) Thanks, Pedro Alves