From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 108722 invoked by alias); 15 Jun 2015 13:00:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 107903 invoked by uid 89); 15 Jun 2015 13:00:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-pa0-f44.google.com Received: from mail-pa0-f44.google.com (HELO mail-pa0-f44.google.com) (209.85.220.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Mon, 15 Jun 2015 13:00:27 +0000 Received: by pacgb13 with SMTP id gb13so35189716pac.1 for ; Mon, 15 Jun 2015 06:00:25 -0700 (PDT) X-Received: by 10.66.218.6 with SMTP id pc6mr47788567pac.20.1434373225831; Mon, 15 Jun 2015 06:00:25 -0700 (PDT) Received: from [127.0.0.1] (gcc1-power7.osuosl.org. [140.211.15.137]) by mx.google.com with ESMTPSA id ve1sm12206762pbc.52.2015.06.15.06.00.24 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 15 Jun 2015 06:00:25 -0700 (PDT) Message-ID: <557ECC66.5060606@gmail.com> Date: Mon, 15 Jun 2015 13:00:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Martin Simmons , gdb-patches@sourceware.org Subject: Re: [PATCH] Fix compilation of gdb/arm-linux-nat.c on Raspbian GNU/Linux 7 References: <201506151243.t5FChjwS012722@heapu.cam.lispworks.com> In-Reply-To: <201506151243.t5FChjwS012722@heapu.cam.lispworks.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2015-06/txt/msg00300.txt.bz2 This patch is OK, except for the ChangeLog entry, it can be rewritten like On 15/06/15 13:43, Martin Simmons wrote: > gdb/ChangeLog > > * arm-linux-nat.c (nat/linux-ptrace.h): New include for > PTRACE_GETREGSET et al in case of old system header files. * arm-linux-nat.c: Include nat/linux-ptrace.h. because we put what do we change in the changelog rather than "why". Do you have the commit access to gdb git repository? -- Yao (齐尧)