From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 114109 invoked by alias); 12 Jun 2015 12:33:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 114096 invoked by uid 89); 12 Jun 2015 12:33:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 12 Jun 2015 12:33:23 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id 65F0AC79E1; Fri, 12 Jun 2015 12:33:22 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t5CCXKU9025987; Fri, 12 Jun 2015 08:33:21 -0400 Message-ID: <557AD190.9080104@redhat.com> Date: Fri, 12 Jun 2015 12:33:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Antoine Tremblay , gdb-patches@sourceware.org Subject: Re: [PATCH v3] Fix MI dprintf-insert not printing on a resolved pending location. References: <5534ED92.1010604@ericsson.com> <1434112052-6972-1-git-send-email-antoine.tremblay@ericsson.com> In-Reply-To: <1434112052-6972-1-git-send-email-antoine.tremblay@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-06/txt/msg00251.txt.bz2 On 06/12/2015 01:27 PM, Antoine Tremblay wrote: > --- > Diffs in v3 : > - some syntax formating for int main > - wording changes to make it more clear that the pending location is now resolved > - more explicit mi_expect_stop Thanks. That does make it more obvious what is going on here. > This patch fixes the "Format string required" error when trying to print > a dprintf on a now resolved, pending location when set via the MI interface > even if the format string is entered correctly. > > This patch also adds a test case to check that issue called > mi-dprintf-pending.exp. > OK with: > +extern void pendfunc (); (void) here too. Thank you and thanks Keith too. -- Pedro Alves