From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 71267 invoked by alias); 11 Jun 2015 20:10:33 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 71251 invoked by uid 89); 11 Jun 2015 20:10:33 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 11 Jun 2015 20:10:32 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 8ADC8374A17 for ; Thu, 11 Jun 2015 20:10:31 +0000 (UTC) Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t5BKAUI7023799 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 11 Jun 2015 16:10:31 -0400 Message-ID: <5579EB36.9010500@redhat.com> Date: Thu, 11 Jun 2015 20:10:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Sergio Durigan Junior CC: gdb-patches@sourceware.org Subject: Re: [RFA/testsuite] Regexp-escape command in capture_command_output References: <20150519221428.769.46872.stgit@valrhona.uglyboxes.com> <555BB8E7.4010906@redhat.com> <87twuevz8b.fsf@redhat.com> In-Reply-To: <87twuevz8b.fsf@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-06/txt/msg00233.txt.bz2 On 06/11/2015 12:09 PM, Sergio Durigan Junior wrote: >>> diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp >>> index 73e55e3..fe7dd60 100644 >>> --- a/gdb/testsuite/lib/gdb.exp >>> +++ b/gdb/testsuite/lib/gdb.exp >>> @@ -5185,7 +5185,7 @@ proc capture_command_output { command prefix } { >>> >>> set output_string "" >>> gdb_test_multiple "$command" "capture_command_output for $command" { >>> - -re "${command}\[\r\n\]+${prefix}(.*)\[\r\n\]+$gdb_prompt $" { >>> + -re "[string_to_regexp ${command}]\[\r\n\]+${prefix}(.*)\[\r\n\]+$gdb_prompt $" { >>> set output_string $expect_out(1,string) > > The patch looks correct, but shouldn't we convert ${prefix} to regexp as > well? Actually, no, we shouldn't. Prefix is supposed to be a regexp that expect can grok. Much of the test suite already relies on this; in gdb.base/completion.exp: set regs_output [capture_command_output "mt print registers" \ ".*Name.*Nr.*Rel.*Offset.*Size.*Type.\[^\n\]*\n"] Keith