Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@ericsson.com>
To: Doug Evans <dje@google.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 4/6] DWARF Two Level Line Tables: lnp_state_machine, lnp_reader_state
Date: Wed, 10 Jun 2015 20:35:00 -0000	[thread overview]
Message-ID: <55789FA8.6070901@ericsson.com> (raw)
In-Reply-To: <CADPb22Sfg2-dPUM81b+cjNMOwTfUiz0pfW+5XvcfbE_VXd6vkA@mail.gmail.com>

> Yikes.
> My bad, thanks for catching this.
> 
> LGTM

Thanks. I pushed this:

From e815d2d2714a395d11abb350eff385931257ed9a Mon Sep 17 00:00:00 2001
From: Simon Marchi <simon.marchi@ericsson.com>
Date: Wed, 10 Jun 2015 16:34:16 -0400
Subject: [PATCH] dwarf2read: call dwarf_finish_line when ending a sequence

Commit d9b3de22f33e400f7f409cce3acf6c7dab07dd79 introduced a behaviour
change where dwarf_finish_line was not called anymore when ending a
sequence of machine instructions. This patch restores the original
behaviour.

gdb/ChangeLog:

	* dwarf2read.c (dwarf_record_line): Call dwarf_record_line if
	 end_sequence is true.
---
 gdb/ChangeLog    | 5 +++++
 gdb/dwarf2read.c | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 5b19052..872d88a 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2015-06-10  Simon Marchi  <simon.marchi@ericsson.com>
+
+	* dwarf2read.c (dwarf_record_line): Call dwarf_record_line if
+	end_sequence is true.
+
 2015-06-10  Jan Kratochvil  <jan.kratochvil@redhat.com>

 	Code cleanup.
diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c
index 1e290c3..d79b2e3 100644
--- a/gdb/dwarf2read.c
+++ b/gdb/dwarf2read.c
@@ -17658,7 +17658,7 @@ dwarf_record_line (lnp_reader_state *reader, lnp_state_machine *state,
       lh->file_names[file - 1].included_p = 1;
       if (reader->record_lines_p && is_stmt)
 	{
-	  if (state->last_subfile != current_subfile)
+	  if (state->last_subfile != current_subfile || end_sequence)
 	    {
 	      dwarf_finish_line (reader->gdbarch, state->last_subfile,
 				 state->address, state->record_line);
-- 
2.1.4


  reply	other threads:[~2015-06-10 20:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-27 22:22 Doug Evans
2015-06-10 19:44 ` Simon Marchi
2015-06-10 20:04   ` Doug Evans
2015-06-10 20:35     ` Simon Marchi [this message]
  -- strict thread matches above, loose matches on Subject: below --
2015-03-12 20:05 Doug Evans

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55789FA8.6070901@ericsson.com \
    --to=simon.marchi@ericsson.com \
    --cc=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox