From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3267 invoked by alias); 10 Jun 2015 15:12:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3178 invoked by uid 89); 10 Jun 2015 15:12:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 10 Jun 2015 15:11:29 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id E7FFF8E67C; Wed, 10 Jun 2015 15:11:27 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t5AFBQaa005711; Wed, 10 Jun 2015 11:11:27 -0400 Message-ID: <5578539E.1020806@redhat.com> Date: Wed, 10 Jun 2015 15:12:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Patrick Palka CC: "gdb-patches@sourceware.org" Subject: Re: [PATCH] Add option to remove duplicate command history entries References: <1433434918-30948-1-git-send-email-patrick@parcs.ath.cx> <55772C02.5080602@redhat.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-06/txt/msg00190.txt.bz2 On 06/09/2015 07:40 PM, Patrick Palka wrote: > On Tue, Jun 9, 2015 at 2:10 PM, Pedro Alves wrote: >> On 06/04/2015 05:21 PM, Patrick Palka wrote: >>> This patch implements the new option "history remove-duplicates", which >>> controls whether GDB should remove duplicate command-history entries >>> (off by default). >>> >>> The motivation for this option is to be able to reduce the prevalence of >>> basic commands such as "up" and "down" in the history file. These >>> common commands crowd out more unique commands in the history file (when >>> the history file has a fixed size), and they make navigation of the >>> history file via ^P, ^N and ^R more inconvenient. >>> >> >> Did you consider bash's erasedups and ignoredups? Specifically, >> this seems to implement something like erasedups, and I'm wondering >> how you'd fit in ignoredups in this option's UI. Might be good to >> prepare for it with an enum instead, something like: >> >> "set history duplicates ignore|erase|leave" >> >> WDYT? > > An "ignoredups" option currently seems not useful in GDB since we > already have the empty-command shorthand for running the previous > command again, which does not add to the history. But if we ever make > the empty-command shorthand toggle-able then an "ignoredups" > equivalent could be useful when the shorthand is turned off. I am > actually thinking about implementing that too, since I do not like the > shorthand very much and would like to be able to turn it off. So I > might as well implement "ignoredups" too. Alright, sounds good. I like the shorthand myself, but then that's why these things have knobs. :-) Thanks, Pedro Alves