From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 63844 invoked by alias); 9 Jun 2015 18:10:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 63831 invoked by uid 89); 9 Jun 2015 18:10:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 09 Jun 2015 18:10:13 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 77A2FB6E99; Tue, 9 Jun 2015 18:10:12 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t59IABT6001596; Tue, 9 Jun 2015 14:10:11 -0400 Message-ID: <55772C02.5080602@redhat.com> Date: Tue, 09 Jun 2015 18:10:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Patrick Palka , gdb-patches@sourceware.org Subject: Re: [PATCH] Add option to remove duplicate command history entries References: <1433434918-30948-1-git-send-email-patrick@parcs.ath.cx> In-Reply-To: <1433434918-30948-1-git-send-email-patrick@parcs.ath.cx> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-06/txt/msg00139.txt.bz2 On 06/04/2015 05:21 PM, Patrick Palka wrote: > This patch implements the new option "history remove-duplicates", which > controls whether GDB should remove duplicate command-history entries > (off by default). > > The motivation for this option is to be able to reduce the prevalence of > basic commands such as "up" and "down" in the history file. These > common commands crowd out more unique commands in the history file (when > the history file has a fixed size), and they make navigation of the > history file via ^P, ^N and ^R more inconvenient. > Did you consider bash's erasedups and ignoredups? Specifically, this seems to implement something like erasedups, and I'm wondering how you'd fit in ignoredups in this option's UI. Might be good to prepare for it with an enum instead, something like: "set history duplicates ignore|erase|leave" WDYT? (haven't looked at the patch yet) Thanks, Pedro Alves