From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 58484 invoked by alias); 29 May 2015 10:29:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 58458 invoked by uid 89); 29 May 2015 10:29:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 29 May 2015 10:29:54 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (Postfix) with ESMTPS id C5E68B7A80; Fri, 29 May 2015 10:29:53 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t4TATonl011768; Fri, 29 May 2015 06:29:52 -0400 Message-ID: <55683F9E.7020902@redhat.com> Date: Fri, 29 May 2015 10:29:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Roland McGrath , GDB CC: "binutils@sourceware.org" Subject: Re: [PATCH users/roland/osabi] Recognize GNU .note.ABI-tag values 5 (syllable) and 6 (nacl) References: In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-05/txt/msg00708.txt.bz2 On 05/29/2015 02:10 AM, Roland McGrath wrote: > These two values are assigned in glibc trunk (5 has been assigned to > syllable for several years, and 6 is quite recent). I don't actually know > anything about Syllable, but IMHO it makes sense for the other GNU packages > that think about these values at all (binutils/gdb) to grok all the values > that exist in the GNU package that owns this number space (libc). > > OK for trunk and gdb's 7.9 branch? (I don't really care about the readelf > change, but I'm happy to put it on binutils' 2.25 branch if anyone thinks > it's worthwhile.) I think adding the constants to include/elf/common.h, and making generic_elf_osabi_sniff_abi_tag_sections recognize syllable and nacl, avoiding the internal_error (or warning after your other patch) is OK and could go to the 7.9 branch. Please split that out to a separate patch. The rest of the gdb bits can be considered for trunk. I don't think we want GDB_OSABI_SYLLABLE exposed to the rest of the gdb (I don't know anything about Syllable either), and to users (both "set osabi" and xml target descriptions). We may need to expose GDB_OSABI_NACL, but that's probably best added along with the nacl port, assuming there's one. Thanks, Pedro Alves