From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-123232-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 20866 invoked by alias); 29 May 2015 09:32:26 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 20855 invoked by uid 89); 29 May 2015 09:32:25 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 29 May 2015 09:32:25 +0000
Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])	by mx1.redhat.com (Postfix) with ESMTPS id 12784B7A64;	Fri, 29 May 2015 09:32:24 +0000 (UTC)
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t4T9WMgG030554;	Fri, 29 May 2015 05:32:23 -0400
Message-ID: <55683226.5050302@redhat.com>
Date: Fri, 29 May 2015 09:32:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: Patrick Palka <patrick@parcs.ath.cx>, gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] Tweak the handling of $GDBHISTSIZE edge cases [PR gdb/16999]
References: <1432293831-23599-1-git-send-email-patrick@parcs.ath.cx> <1432293831-23599-2-git-send-email-patrick@parcs.ath.cx>
In-Reply-To: <1432293831-23599-2-git-send-email-patrick@parcs.ath.cx>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-SW-Source: 2015-05/txt/msg00704.txt.bz2

On 05/22/2015 12:23 PM, Patrick Palka wrote:

> +      while (isspace (*tmpenv))
> +	tmpenv++;

...

> +
> +      while (isspace (*endptr))
> +	endptr++;

Use skip_spaces/skip_spaces_const for these.

Otherwise looks good to me.

(I suspect that testing the interaction between setting
the history both from a .gdbinit and $GDBHISTSIZE would
call for merging the gdbhistsize-history.exp / gdbinit-history.exp
to a single file.)

Thanks,
Pedro Alves