From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 62125 invoked by alias); 27 May 2015 14:12:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 62116 invoked by uid 89); 27 May 2015 14:12:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: e24smtp04.br.ibm.com Received: from e24smtp04.br.ibm.com (HELO e24smtp04.br.ibm.com) (32.104.18.25) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Wed, 27 May 2015 14:12:18 +0000 Received: from /spool/local by e24smtp04.br.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 27 May 2015 11:12:13 -0300 Received: from d24dlp01.br.ibm.com (9.18.248.204) by e24smtp04.br.ibm.com (10.172.0.140) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 27 May 2015 11:12:11 -0300 Received: from d24relay02.br.ibm.com (d24relay02.br.ibm.com [9.13.184.26]) by d24dlp01.br.ibm.com (Postfix) with ESMTP id 012643520064 for ; Wed, 27 May 2015 10:11:07 -0400 (EDT) Received: from d24av05.br.ibm.com (d24av05.br.ibm.com [9.18.232.44]) by d24relay02.br.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t4REAtLJ39321674 for ; Wed, 27 May 2015 11:10:56 -0300 Received: from d24av05.br.ibm.com (localhost [127.0.0.1]) by d24av05.br.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t4REC9Pu019260 for ; Wed, 27 May 2015 10:12:09 -0400 Received: from [9.8.6.171] ([9.8.6.171]) by d24av05.br.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id t4REC9Ii019253; Wed, 27 May 2015 10:12:09 -0400 Message-ID: <5565D0B8.7090602@linux.vnet.ibm.com> Date: Wed, 27 May 2015 14:12:00 -0000 From: Edjunior Barbosa Machado User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Yao Qi CC: Pedro Alves , gdb-patches@sourceware.org Subject: Re: [PATCH 2/4] Implements aarch64 process record and reverse debugging support References: <1432041752-4638-1-git-send-email-yao.qi@linaro.org> <1432041752-4638-3-git-send-email-yao.qi@linaro.org> <555E3EAE.2080107@redhat.com> <86h9qzr2g2.fsf@gmail.com> <5564D0E9.3000402@linux.vnet.ibm.com> <86d21mqvl0.fsf@gmail.com> <868ucaqq0o.fsf@gmail.com> In-Reply-To: <868ucaqq0o.fsf@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15052714-0029-0000-0000-000003A39CA7 X-IsSubscribed: yes X-SW-Source: 2015-05/txt/msg00660.txt.bz2 On 05/27/2015 07:21 AM, Yao Qi wrote: > Yao Qi writes: > >>> gcc -g -O2 -mminimal-toc -I. -I../../gdb -I../../gdb/common -I../../gdb/config -DLOCALEDIR="\"/usr/local/share/locale\"" -DHAVE_CONFIG_H -I../../gdb/../include/opcode -I../../gdb/../opcodes/.. -I../../gdb/../readline/.. -I../../gdb/../zlib -I../bfd -I../../gdb/../bfd -I../../gdb/../include -I../libdecnumber -I../../gdb/../libdecnumber -I../../gdb/gnulib/import -Ibuild-gnulib/import -DTUI=1 -I/usr/include/python2.7 -I/usr/include/python2.7 -Wall -Wpointer-arith -Wno-unused -Wunused-value -Wunused-function -Wno-switch -Wno-char-subscripts -Wempty-body -Wpointer-sign -Wmissing-prototypes -Wdeclaration-after-statement -Wmissing-parameter-type -Wold-style-declaration -Wold-style-definition -Wformat-nonliteral -Werror -c -o aarch64-tdep.o -MT aarch64-tdep.o -MMD -MP -MF .deps/aarch64-tdep.Tpo ../../gdb/aarch64-tdep.c >>> ../../gdb/aarch64-tdep.c: In function ‘aarch64_process_record’: >>> ../../gdb/aarch64-tdep.c:2823:23: error: ‘record_buf[0]’ may be used uninitialized in this function [-Werror=maybe-uninitialized] >>> memcpy(®S[0], &RECORD_BUF[0], sizeof(uint32_t)*LENGTH); \ >>> ^ >>> ../../gdb/aarch64-tdep.c:3529:12: note: ‘record_buf[0]’ was declared here >>> uint32_t record_buf[2]; >>> ^ >>> >>> The simple patch below intends to fix this. Ok? >> >> This build error reveals some logic error inside function >> aarch64_record_data_proc_simd_fp on decoding instructions. I'll take a look. > > Here is the patch below, it fixes the build failure on my machine. Does > it work for you too? > Hi Yao, unfortunately I was unable to apply your patch due to the follow: $ patch -p1 -i ~/fix.patch --dry (Stripping trailing CRs from patch; use --binary to disable.) checking file gdb/aarch64-tdep.c patch: **** malformed patch at line 6: *aarch64_insn_r) -- Edjunior