From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 63201 invoked by alias); 23 May 2015 12:11:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 63186 invoked by uid 89); 23 May 2015 12:11:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Sat, 23 May 2015 12:11:46 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 386CA8E4E4; Sat, 23 May 2015 12:11:45 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t4NCBh0q030715; Sat, 23 May 2015 08:11:44 -0400 Message-ID: <55606E7F.7010306@redhat.com> Date: Sat, 23 May 2015 12:11:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Don Breazeal , gdb-patches@sourceware.org Subject: Re: [PATCH 3/3] Disable exec-dependent follow fork tests for remote References: <1432320931-1550-1-git-send-email-donb@codesourcery.com> <1432320931-1550-4-git-send-email-donb@codesourcery.com> In-Reply-To: <1432320931-1550-4-git-send-email-donb@codesourcery.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-05/txt/msg00621.txt.bz2 On 05/22/2015 07:55 PM, Don Breazeal wrote: > The native-extended-gdbserver target now supports fork events and > follow fork, but it does not yet support exec events. Some of the > tests in gdb.base/foll-vfork.exp depend on exec events. This patch > disables those tests for gdbserver targets. We can re-enable these > once the exec event support goes in. > > OK? Pedantically, I think this should check gdb_is_target_remote instead. We lack support for exec events in the RSP, so this would fail for any remote protocol stub, not just our gdbserver. > > --Don > > > gdb/testsuite/ > 2015-05-22 Don Breazeal > > * gdb.base/foll-vfork.exp (main): Disable exec-dependent > tests for remote targets by checking is_target_gdbserver. > > --- > gdb/testsuite/gdb.base/foll-vfork.exp | 28 ++++++++++++++++------------ > 1 file changed, 16 insertions(+), 12 deletions(-) > > diff --git a/gdb/testsuite/gdb.base/foll-vfork.exp b/gdb/testsuite/gdb.base/foll-vfork.exp > index 78c5cc8..26d7afd 100644 > --- a/gdb/testsuite/gdb.base/foll-vfork.exp > +++ b/gdb/testsuite/gdb.base/foll-vfork.exp > @@ -524,18 +524,22 @@ with_test_prefix "check vfork support" { > check_vfork_catchpoints > } > > -# Follow parent and follow child vfork tests with a child that execs. > -with_test_prefix "exec" { > - # These are tests of gdb's ability to follow the parent of a Unix > - # vfork system call. The child will subsequently call a variant > - # of the Unix exec system call. > - do_vfork_and_follow_parent_tests > - > - # These are tests of gdb's ability to follow the child of a Unix > - # vfork system call. The child will subsequently call a variant > - # of a Unix exec system call. > - # > - do_vfork_and_follow_child_tests_exec > +if { ![target_is_gdbserver] } { > + # Follow parent and follow child vfork tests with a child that execs. > + with_test_prefix "exec" { > + # These are tests of gdb's ability to follow the parent of a Unix > + # vfork system call. The child will subsequently call a variant > + # of the Unix exec system call. > + do_vfork_and_follow_parent_tests > + > + # These are tests of gdb's ability to follow the child of a Unix > + # vfork system call. The child will subsequently call a variant > + # of a Unix exec system call. > + # > + do_vfork_and_follow_child_tests_exec > + } > +} else { > + untested "vfork with exec: exec events not supported for remote" 'git am' caught that there's a spurious space at the end of this line. Please remove it. OK with these changes. > } > > # Switch to test the case of the child exiting. We can't use > Thanks! -- Pedro Alves