From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 46925 invoked by alias); 22 May 2015 10:00:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 46911 invoked by uid 89); 22 May 2015 10:00:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 22 May 2015 10:00:34 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 4ED448EA21; Fri, 22 May 2015 10:00:33 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t4MA0V6h025691; Fri, 22 May 2015 06:00:32 -0400 Message-ID: <555EFE3F.2080903@redhat.com> Date: Fri, 22 May 2015 10:00:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Patrick Palka CC: "gdb-patches@sourceware.org" Subject: Remove HISTSIZE env var altogether? (was: Re: [PATCH] Tweak the handling of $HISTSIZE edge cases [PR gdb/16999]) References: <1432248648-7402-1-git-send-email-patrick@parcs.ath.cx> <555E6B60.8040802@redhat.com> <555E7B52.6050100@redhat.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-05/txt/msg00601.txt.bz2 Changing title to call for attention. Maybe we should ask on gdb@. Background here: https://sourceware.org/ml/gdb-patches/2015-05/msg00349.html https://sourceware.org/ml/gdb-patches/2015-05/msg00563.html > What do you think about removing HISTSIZE/GDBHISTSIZE support > altogether? It is awfully redundant (we can already automatically set > the history size via .gdbinit or via -ex "set history size foo") and > thus not really useful. Even if we go along with replacing HISTSIZE > with GDBHISTSIZE I just can't see much use for it. What about GDBHISTFILE? I think that the rationale for the existence of one should apply to both. (with the HISTSIZE vs GDBHISTSIZE distinction being a separate matter.) I'm really not sure. Trying to play devil's advocate: #1 - An env var can be set once, for all users. But that can be done with --with-system-gdbinit=FILE as well. #2 - Along with GDBHISTFILE, it survives -nx. Does it really matter? I don't know. #3 - Seems friendly to allow at least GDBHISTFILE be an env var so it can easily be toggled per host. Though that can be done through Python inside .gdbinit nowadays. Though^2, Python isn't always available. OTOH, I'm getting more convinced that we should at least rename HISTSIZE -> GDBHISTSIZE. The cost of keeping that doesn't seem to be much. Thanks, Pedro Alves