Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Yao Qi <qiyaoltc@gmail.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 2/4] Implements aarch64 process record and reverse debugging support
Date: Thu, 21 May 2015 20:23:00 -0000	[thread overview]
Message-ID: <555E3EAE.2080107@redhat.com> (raw)
In-Reply-To: <1432041752-4638-3-git-send-email-yao.qi@linaro.org>

On 05/19/2015 02:22 PM, Yao Qi wrote:
> 	* linux-record.h (struct linux_record_tdep): Add two more syscall
> 	argument fields.

Off by one?

Looked fine to me otherwise (I just skimmed it; didn't really look at
anything aarch64 specific in detail).

Thanks,
Pedro Alves


  reply	other threads:[~2015-05-21 20:23 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-19 13:22 [PATCH 0/4 V6] Process record and reverse debugging support on aarch64-linux Yao Qi
2015-05-19 13:22 ` [PATCH 2/4] Implements aarch64 process record and reverse debugging support Yao Qi
2015-05-21 20:23   ` Pedro Alves [this message]
2015-05-26 11:41     ` Yao Qi
2015-05-26 20:00       ` Edjunior Barbosa Machado
2015-05-27  8:21         ` Yao Qi
2015-05-27  9:23           ` Yao Qi
2015-05-27 10:22           ` Yao Qi
2015-05-27 14:12             ` Edjunior Barbosa Machado
2015-05-27 15:05               ` Yao Qi
     [not found]                 ` <5565E8BE.4060506@linux.vnet.ibm.com>
2015-05-27 16:18                   ` Yao Qi
2015-05-19 13:22 ` [PATCH 1/4] NEWS entry about aarch64-linux record/replay support Yao Qi
2015-05-19 13:23 ` [PATCH 4/4] New gdb.reverse test case for aarch64 instructions Yao Qi
2015-05-21 20:22   ` Pedro Alves
2015-05-26 11:26     ` Yao Qi
2015-05-19 13:23 ` [PATCH 3/4] Enables gdb.reverse testsuite for aarch64*-linux targets Yao Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=555E3EAE.2080107@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=qiyaoltc@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox