From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 40377 invoked by alias); 21 May 2015 17:45:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 40341 invoked by uid 89); 21 May 2015 17:45:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 21 May 2015 17:45:01 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t4LHive0023069 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 21 May 2015 13:44:57 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t4LHit1U016358; Thu, 21 May 2015 13:44:56 -0400 Message-ID: <555E1997.2070805@redhat.com> Date: Thu, 21 May 2015 17:45:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH v2 1/7] Various cleanups in target read/write code References: <1429127258-1033-1-git-send-email-simon.marchi@ericsson.com> <1429127258-1033-2-git-send-email-simon.marchi@ericsson.com> In-Reply-To: <1429127258-1033-2-git-send-email-simon.marchi@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-05/txt/msg00546.txt.bz2 On 04/15/2015 08:47 PM, Simon Marchi wrote: > This contains various cleanups in the target memory read and write code. > They are not directly related to the non-8-bits changes, but they > clarify things a bit down the line. > > gdb/ChangeLog: > > * target.c (target_read): Rename variables and use > TARGET_XFER_E_IO. > (target_read_with_progress): Same. > (read_memory_robust): Constify parameters and rename > variables. > (read_whatever_is_readable): Constify parameters, > rename variables, adjust formatting. > * target.h (read_memory_robust): Constify parameters. OK. Thanks, Pedro Alves