From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 39480 invoked by alias); 21 May 2015 17:44:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 39470 invoked by uid 89); 21 May 2015 17:44:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 21 May 2015 17:44:44 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id C79D63620B7; Thu, 21 May 2015 17:44:43 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t4LHigiG021327; Thu, 21 May 2015 13:44:42 -0400 Message-ID: <555E1989.7010407@redhat.com> Date: Thu, 21 May 2015 17:44:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH v2 0/7] Support reading/writing memory on architectures with non 8-bits addressable memory References: <1429127258-1033-1-git-send-email-simon.marchi@ericsson.com> In-Reply-To: <1429127258-1033-1-git-send-email-simon.marchi@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-05/txt/msg00545.txt.bz2 On 04/15/2015 08:47 PM, Simon Marchi wrote: > > For RSP's m, M and X packets, the "length" parameters are used to > correctly encode or decode the packet at a low level, where we don't > want to have to deal with different target byte sizes. Also, for a > network protocol, it would make sense to use a fixed-sized unit. > Therefore, it would be easier if those lengths were always in bytes. > Here is an example that corresponds to the previous MI example. This confuses me and gives me lots of pause. My immediate reaction is, "well, that's odd. what's different compared to MI here?". I'm not imagining what exactly ends up being easier? But anyway, I guess it's a small detail. I'll review ignoring that. > > -> $m1000,8#?? > <- aaaabbbbccccdddd > > -> $M1000,6:eeeeffffeeee#?? > <- OK > > -> $m1000,8#?? > <- eeeeffffeeeedddd > > If there are any other RSP packets or MI commands that need such > clarification, it will be on a case-by-case basis, whatever makes more > sense for each particular one. Off hand, I thought of qCRC and qSearch:memory. The latter is more interesting: - Would you allow searching for an 1 8-bit byte pattern? - So what length would you use for that one? Host byte or addressable units? Thanks, Pedro Alves