From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2368 invoked by alias); 21 May 2015 15:04:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 2358 invoked by uid 89); 21 May 2015 15:04:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 21 May 2015 15:04:12 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t4LF48go015436 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 21 May 2015 11:04:08 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t4LF45J0001064; Thu, 21 May 2015 11:04:06 -0400 Message-ID: <555DF3E5.8090104@redhat.com> Date: Thu, 21 May 2015 15:04:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Gary Benson , gdb-patches@sourceware.org CC: Eli Zaretskii , Doug Evans , =?windows-1252?Q?Iago_L=F3pez_Galeiras?= Subject: Re: [PATCH 7/9 v2] Implement multiple-filesystem support for remote targets References: <1429186791-6867-1-git-send-email-gbenson@redhat.com> <1430395542-16017-8-git-send-email-gbenson@redhat.com> In-Reply-To: <1430395542-16017-8-git-send-email-gbenson@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-05/txt/msg00544.txt.bz2 On 04/30/2015 01:05 PM, Gary Benson wrote: > @@ -9890,6 +9935,9 @@ remote_hostio_open (struct target_ops *self, > char *p = rs->buf; > int left = get_remote_packet_size () - 1; > > + if (remote_hostio_set_filesystem (inf, remote_errno) != 0) > + return -1; I guess this is where the ENOSYS issue (and likewise in the native target) we were discussing before (in the vgdb patch) comes from. I'm not yet convinced it's a good idea to have setns==ENOSYS result in open==ENOSYS. Other than this issue, the whole series looks good to me. Thanks, Pedro Alves