From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 87566 invoked by alias); 21 May 2015 14:56:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 87547 invoked by uid 89); 21 May 2015 14:56:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 21 May 2015 14:56:21 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id C2E5C3674AB; Thu, 21 May 2015 14:56:19 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t4LEuHV3006583; Thu, 21 May 2015 10:56:18 -0400 Message-ID: <555DF210.5080005@redhat.com> Date: Thu, 21 May 2015 14:56:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Gary Benson , gdb-patches@sourceware.org CC: Eli Zaretskii , Doug Evans , =?windows-1252?Q?Iago_L=F3pez_Galeiras?= Subject: Re: [PATCH 1/9 v2] Move make_cleanup_close to common code References: <1429186791-6867-1-git-send-email-gbenson@redhat.com> <1430395542-16017-2-git-send-email-gbenson@redhat.com> In-Reply-To: <1430395542-16017-2-git-send-email-gbenson@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-05/txt/msg00537.txt.bz2 On 04/30/2015 01:05 PM, Gary Benson wrote: > This commit moves the function make_cleanup_close from gdb/utils.[ch] > to gdb/common/cleanup-utils.[ch] to make it usable from common code. > A new file was created over putting the function in common-utils.[ch] > to avoid having to build cleanups.c into the in-process agent. > Hmm, how about avoiding creating another kitchensync, and putting this in common/filestuff.[ch]? Thanks, Pedro Alves