Re: [PATCH v4 6/9] Explicit locations: introduce explicit locations

Pedro Alves
2015-05-19T22:09:08Z

On 05/18/2015 09:14 PM, Keith Seitz wrote:
> On 05/17/2015 11:12 PM, Doug Evans wrote:
>> Not something to be done now, but just curious.
>> Do we support source file names with spaces?
>
> Good question! My *guess* would be: it should! I certainly remember
> fiddling with this, and explicit_location_lex_one does have handling for
> it. [The lexer also allows quote-enclosed strings, just like linespec.]
>
> I just tested it (to be certain), and (survey says!):
>
> (gdb) fil ~/tmp/file\ with\ spaces
> Reading symbols from ~/tmp/file with spaces...done.
> (gdb) b -source file with spaces.c -line 4

Eh, do we handle files with spaces without requiring quoting
anywhere else? The potential for ambiguity makes me a bit nervous
to claim we support that.

> Breakpoint 1 at 0x4004fa: file /home/keiths/tmp/file with spaces.c, line 4.
> (gdb) r
> Starting program: /home/keiths/tmp/file with spaces
>
> Breakpoint 1, main () at /home/keiths/tmp/file with spaces.c:4
> 4 return 1;
> (gdb)
>
> ls-errs.exp exercises this a bit, too, albeit in a non-obvious way.

Thanks,
Pedro Alves