From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32590 invoked by alias); 19 May 2015 22:10:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32580 invoked by uid 89); 19 May 2015 22:10:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 19 May 2015 22:10:30 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id EEFEF8F010 for ; Tue, 19 May 2015 22:10:28 +0000 (UTC) Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t4JMASuc029199 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Tue, 19 May 2015 18:10:28 -0400 Message-ID: <555BB4D4.6000603@redhat.com> Date: Tue, 19 May 2015 22:10:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: Re: [PATCH v5] Explicit locations: use new location API References: <20150519215741.32695.31475.stgit@valrhona.uglyboxes.com> In-Reply-To: <20150519215741.32695.31475.stgit@valrhona.uglyboxes.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-05/txt/msg00504.txt.bz2 On 05/19/2015 02:57 PM, Keith Seitz wrote: > Differences in this revision: > > 1. Fixed typos > 2. Changed error-handling in linespec_lex_to_end. > 3. Remove unused references to copy_event_location_tmp. Sorry, that's actually the diffs for a different patch. For this patch, originally #3/9: 1. Remove superfluous fencepost from strace_marker_create_sals_from_location. 2. Add assert for b->cond_string to location_to_sals. Keith