From: Luis Machado <lgustavo@codesourcery.com>
To: John Baldwin <jhb@freebsd.org>
Cc: <gdb-patches@sourceware.org>, <binutils@sourceware.org>,
"Maciej W. Rozycki" <macro@linux-mips.org>,
Mark Kettenis <mark.kettenis@xs4all.nl>
Subject: Re: [PATCH v3 2/3] Add FreeBSD/mips architecture.
Date: Thu, 05 Jan 2017 00:52:00 -0000 [thread overview]
Message-ID: <5558a939-1a9e-1e22-6b53-a3d710dcb522@codesourcery.com> (raw)
In-Reply-To: <1705214.U73jUJvlEx@ralph.baldwin.cx>
On 01/04/2017 04:10 PM, John Baldwin wrote:
> On Wednesday, January 04, 2017 03:23:00 PM Luis Machado wrote:
>> Hi,
>>
>> Did this get pushed? I thought we were waiting for Maciej to provide
>> feedback?
>
> I did not push the binutils change, only the gdb ones (they are independent).
> Between Pedro's earlier comments and yours (which I had taken as approval),
> I figured the GDB ones were fine and didn't want to keep reposting them while
> hashing out the binutils change. (I've seen some other patch series go by
> where a subset of patches were committed earlier while other patches were
> reworked.)
>
I see.
>> Also please note i only review, i don't approve. Mark Kettenis would be
>> the one to approve native FreeBSD bits (if the MAINTAINERS file is still
>> up-to-date).
>>
>> Or maybe that has changed? If so, the MAINTAINERS file needs to be updated.
>
> Hmm, I misinterpreted your comments as approval then. Most of my recent
> FreeBSD changes have been approved by Pedro Alves.
>
I apologize if i haven't been clear. I tend to remind people about
waiting for formal approval here and there, but not on every review.
next prev parent reply other threads:[~2017-01-05 0:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-03 18:45 [PATCH v3 0/3] Add FreeBSD/mips targets to GDB John Baldwin
2017-01-03 18:45 ` [PATCH v3 3/3] Add native target for FreeBSD/mips John Baldwin
2017-01-03 19:15 ` Eli Zaretskii
2017-01-03 18:45 ` [PATCH v3 2/3] Add FreeBSD/mips architecture John Baldwin
2017-01-03 19:05 ` Luis Machado
2017-01-03 20:12 ` John Baldwin
2017-01-03 19:16 ` Eli Zaretskii
2017-01-04 21:23 ` Luis Machado
2017-01-04 22:10 ` John Baldwin
2017-01-05 0:52 ` Luis Machado [this message]
2017-01-03 18:45 ` [PATCH v3 1/3] Use bfd_mach_mips4000 as the default machine type for 64-bit MIPS ABIs John Baldwin
2017-01-04 2:09 ` Maciej W. Rozycki
2017-01-04 3:09 ` John Baldwin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5558a939-1a9e-1e22-6b53-a3d710dcb522@codesourcery.com \
--to=lgustavo@codesourcery.com \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=jhb@freebsd.org \
--cc=macro@linux-mips.org \
--cc=mark.kettenis@xs4all.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox