From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-122926-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 30609 invoked by alias); 15 May 2015 16:51:44 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 30599 invoked by uid 89); 15 May 2015 16:51:43 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 15 May 2015 16:51:43 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t4FGpfxU023728	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL)	for <gdb-patches@sourceware.org>; Fri, 15 May 2015 12:51:41 -0400
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t4FGpdcc016435;	Fri, 15 May 2015 12:51:39 -0400
Message-ID: <5556241A.9080602@redhat.com>
Date: Fri, 15 May 2015 16:51:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: Jan Kratochvil <jan.kratochvil@redhat.com>, gdb-patches@sourceware.org
CC: Phil Muldoon <pmuldoon@redhat.com>
Subject: Re: [PATCH v5 5/7] Code cleanup: compile: func_addr -> func_sym
References: <20150513201615.4051.5261.stgit@host1.jankratochvil.net> <20150513201656.4051.30357.stgit@host1.jankratochvil.net>
In-Reply-To: <20150513201656.4051.30357.stgit@host1.jankratochvil.net>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-SW-Source: 2015-05/txt/msg00398.txt.bz2

On 05/13/2015 09:16 PM, Jan Kratochvil wrote:
> Hi,
> 
> currently the code fetches _gdb_expr address/types at multiple places, guessing
> its parameters at multiple places etc.
> 
> Fetch it once, verify it has expected type and then rely on it.
> 
> While the patch tries to clean up the code it is still horrible due to the
> missing C++ sub-classing.
> 

OK.

Thanks,
Pedro Alves