From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.15.18]) by sourceware.org (Postfix) with ESMTPS id 52572387703A for ; Fri, 20 Mar 2020 17:29:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 52572387703A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gmx.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=n54@gmx.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1584725345; bh=pwT1HROMbUrVDse2641JCn/kxR6oEqeMVMW6KV+8R7k=; h=X-UI-Sender-Class:To:Cc:References:From:Subject:Date:In-Reply-To; b=R60Z4CSTfBkw7JQwsmy2EI3KOBfQpxuvi7IFzrz85t9iM05FX6odA2exQK4Y80Iiv flWqz5erwIQQ/V2M8WgNEoaYsl2oFVnxW/Ze7FJKYfy3SiSne6P0TcVCRhFXldVwZm cVCfGpn7Se1ij/j1pbYZR8ACUBFbQtx92kYEX2/o= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.0.241] ([89.79.191.25]) by mail.gmx.com (mrgmx005 [212.227.17.184]) with ESMTPSA (Nemesis) id 1MSbxD-1irJBR3K0n-00SwbV; Fri, 20 Mar 2020 18:29:04 +0100 To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20200314182258.4277-1-n54@gmx.com> <20200316181710.7542-1-n54@gmx.com> <871rpnm3pn.fsf@tromey.com> From: Kamil Rytarowski Autocrypt: addr=n54@gmx.com; prefer-encrypt=mutual; keydata= mQINBFVwUF8BEADHmOg7PFLIcSDdMx5HNDYr8MY2ExGfUTrKwPndbt3peaa5lHsK+UGoPG48 KiWkhEaMmjaXHFa7XgVpJHhFmNoJXfPgjI/sOKTMCPQ5DEHEHTibC4mta7IBAk+rmnaOF0k8 bxHfP8Qbls66wvicrAfTRXn/1ReeNc3NP4Sq39PoVHkfQTlnQiD4eAqBdq61B7DhzjhbKAZ4 RsNtLfB6eOv9qvmblUzs50ChYewM9hvn+c7MdDH+x2UXoSDhkBDkKcJGkX91evos8s9AuoEd D32X5e+bmdUGe8Cr3cAZJ8IEXR6F9828/kxzPliMsCWVRx1Fr28baCJOUGgFPNr3ips78m9+ Iw8PdQ101jU0dvucDFxw/1SCGYEZzV+O/237oRPuLCiDX5nhQoxf6dn9ukQleLBMNy2BLI4H g342NhF21HLA+KlyLOHaMKQCKzlal+zVNZTRTCh/ikMhsxWQjBfnqTDbMj85DnWwtump27SI qhPjUnS0a6MKoS/A+hbi64k5zztkvloELfCSrX7NyBTT0jgF2IGFIxZMrKCtQ9StcGMCV9MX tjcBy6fj7QMontEaIDRJEMjg8UIGw1B687OhalOv1ISia4xOWvpYAM6ipgqh6tBQmFzasL9P h1RtcVdFpFbhwVlr1Bly8c25gBNQHL5GUjLMn45LlQz50OzrkwARAQABtCdLYW1pbCBSeXRh cm93c2tpIChOZXRCU0QpIDxuNTRAZ214LmNvbT6JAjwEEwEIACYCGyMHCwkIBwMCAQYVCAIJ CgsEFgIDAQIeAQIXgAUCVbKGFwIZAQAKCRBLswjpsC52bIVpD/9i8npieI91xMIVvAHIUMeo cQO0IrNb+b/PuTj2qNemdwU7dhVJ7tVU5O1H2hI2M4rHGzjzDTxYzdxka0+A8CVEuvFdf6sF lXlXF0wM7rC6MoaB0QLAKxkZB5OtCILxLx7Bl2Y4cTPMU9v+qSL6yrdmhxogkufa4d6O9Zl/ FCWO2kH/BphKOiDtbyvdo2WULSLWP2IXN+0rCpNL4wbTfYLgV9JtMf8f0naGsdy7BFuDWsIE vtHh8dkQZP7dz6Qy67kx8negZaehSEgXwiae0HwQIn3xTQrFmBDALDsCgXuLWPTvglSkqTak uG+8X5fyTy0cU10TNKsU+rFBO+/xsUoIQOGrARwfWOIfJNPelzh/qigSnyNQNH8u5vFRPg9n fqB/AcvvAvtOYOo8EN9Ofx11gNj397NXc5HBQTrX6k5GNAeBWE3Ng1uO6scIwAS7qGnqGezU ABmQKLN37gmJiiGwhQAnSE6HILLBC5Z2b0S2rQsPKg8WgUmPa1YIcDkDtNB/LJcDsdU4Fm+r U2ksKU7tGD2ZfBt8H2nqfPKKeB+Uv/TBigjRvx/m70vjhqVxwCZA9Fqr9vkQkZroNfqP+3dp Z5V5fjmxO5abE2+IikSvFagwMtgx56i8Yrr2BzE8P5/S4cKq1kgyQoF+lVGDKRkUKCv1i4Fo aftnSxN8jTFZDbkCDQRVcFBfARAAutbzb8wAHGL5FPPWKErQ3Bsrp9RDTVqRzp7kBMOtd/14 MrOsWWyiml4XnvBYsJuhZWomFoeulcOXAPoTJ2vTw6erWYtdOiZymfQ3GMWpxzgkOVeNjsFF 9AQ38FCMKmIDs9dgn+KXSIXlZA34khKLd163SN5U/KHfYlnnocec31u+7rVa1hlF5DBSSpoi s8cs41foBYC5NsB/i+yqGIlfzHy7pC2u5kyQCuJotLH4y0rT5X+YBC7z7cqKChtILNDGw0ht qps29fwOGBE/FWmu8CbpSHj8pvg7uUyQcKbZbNChBfWtOJKdjnNs5VHf2ec95SwYmWl6Xz66 G892HY4ODtvl05/kh0qtdJd2oI4gJBsBx/N1585/3JYN4k78GIHTnML3xJydRRs9wwM3AXf/ iDGrMyY7qHQVXJLdO5nPe7LHg48vryCMkBnTMw5iNFPVCu5w1BaZyHxuS2HvpsgUtQoBa2QE P1jYNI+2qgoiIG4VQDhYtrD0WJaYdi/C2UVDxRy07dt73SV3RQ7ijOiUrz4g3/deFKY16/1k sE+N5Sc5Tjt84ChjO3nJRbHrQxd6dCOElR70e3R2yAuSB4m7LJpO20IB9CtWhlF/0AtfL91W O8GGGqLWB0Z04hmwRs/l8T4WWIlykLshbunWN6jsP1Y27FeilTZ+Pc9mYOEUFfEAEQEAAYkC HwQYAQgACQUCVXBQXwIbDAAKCRBLswjpsC52bPayD/9jE8mdNudrudSxbDB2vf8pU8r5flCq vIkfOdpZGV/Wx/Zx+HFHHp+b2aNBGSNyFTnph1Ku9bvg06vD0o+b7SdA1vrBgRG41t0OCIyf vejz65Xpin2EtCllcBM8zUCxHo43blON8fNw70P1Ec0loBp4TAal1MiXbB8kxRTRcEPVO9YF 9NPsFxycoWl0ZSvu4ESrQlrjRbVv+W0Fy/XqcQwEtDziFQHQXNRbTy8INPD49CsB7BkKRK+f 1vMmw7SxfsyEhyCgo9ZWfHb/+w9T5h+UhF87L/m287z7W+s4aCAPBzjbIWhtngGJJwIgiWdI I9J6YJLcHLvVZLw7xzA/flcjc0VfzOgJOJw3hBukHnEz7/CKgnABwyNu52P+PQbxVTiTjMKm 06eV732u9ZLD9ZgEazfmyGDHzsuzoXwsRnmcnbwYYAiynS+vfGl5oMtMa5qzsPhlzuvRlXHm zr8VjF8c9RThvyZyyHtWYAqNmBecMvM0whigjMeoAMJ5LtpyZgxjbHj1XnVdNBZgfJkOzsc/ twffi7RYphRx0d9z5UZ1Yl5Rvl05vTaJ7YhhNC7xuE8yGOQmDUsPDwWqO/eXUDErJjCOBR5b 0yILqRPYNT0Fj/th9gtEbZy1Gp0TVBkZM3tfjDRu43Pn6iSKObO/j0rNuq1LwN/EMxDifeZO 4XSbcg== Subject: Re: [PATCH v2] Add support for "info auxv" on NetBSD Message-ID: <5554bfd0-3d1f-6aac-93e5-b6067942485a@gmx.com> Date: Fri, 20 Mar 2020 18:27:38 +0100 User-Agent: Mozilla/5.0 (X11; NetBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <871rpnm3pn.fsf@tromey.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="iX2GiQVvurZQzEDctNSWkUAQiYeUmRoVl" X-Provags-ID: V03:K1:J7qHZeA4zhtl1/a18xZr0BjAfp3Dawbjg01DtYZafU81aRcN1CW OHScWeWwt5MF90s7h3uTHuKbjtte8wouf2I2LKWb+UndMCF0FMDpQJhO+U1Raca9nama9Wh OavUcmCxaHoiUtE/G/ga5mHTqBrs4tzalRauY2rwN6sOxd7Sz1frNE+lnV8N4180vLOMhdU ZzenCFY1AE8MeV5mpgUag== X-UI-Out-Filterresults: notjunk:1;V03:K0:6yXG4jOzn0k=:qHJyyXnWPQQsg/DLYLPE63 sLgxw9F7wiZvmz0waMPRmYIMW6M2lc1mE5yp9P5DkVWEeSWWhLqs5oMkSVV0jHWaRn4HskaUh 7sjYKdNtB4Z///Rt5FDKup7xnlFVLCJvP1BxyNNgaCp4djJqg3Aucq6K/9RzpqgbADPJqOvX+ hu1FkVpKqiXxi10JlD2gR6c3D5kUBIMWqQx2s6EyjcKKDp5OGlw266FsvqfH157Y08UoaCYiJ vi5MdBlnRORJFkhSTPaEIlxiRSOeoticibstxCTXNoAp6/Qwfa7g7GapkTkkVZOZVOOTX451m rt0h46ibyhCh8Kfa02UyyVnASuAwWOKSq/QXK/uBMZjqERpAK83Jo8JKARNrzB1ovKnWP/D4h Uz94JLQ+b+/RJkkM+Cz0C6Lvj+hNDq4+WbJnT2u6BvLrIM+Aes497Agb1wYL5Hp97ZpXpGwN6 QbZPO0QIeEysRD6FLm3Elm/eGqqMm9F0pRqC6Fr7FtjFmlX0hkxoZkQ4quUMSQFO8b6kbODfa wktGwFSvPWgPPDyadNRFumiHmRIenycK4bPpnG8WxWtuRV3v+yD4Ev4RRXLmRsY3rWYPyb5KM ag3iaDE0Eo4J0QJJWXFIiVukB7Vw4VRj+VstF6dDuyzVQIBVMBCrY7yOK6AAv7Sz/rk2dCfdu 9RWiGVBHWoln3VSptEEFh7L3AfKr2tQoOu16msDd8h+/CLL+/VvGf07GTFD1YFjYUFLtwUn85 dVIfaVtnlqF5G+6Bq+32iOJSkypOiIK2hT63ASKcGStLsR+ma59dJnzw4rJ39J0FBLbtsQ5Jj nqdJhlDdH+0yZTgojeZnf70cZC3LoSTgL1EZBwijPZupj+PZBVun5hQHlYZKXl0b2UtLgEfow ASs5/YFAeal9sFsNk5+beLwcxeKnL52cc4kTAvhZL5W6qyo2A+fQAARRQIOjXImVfPiNiVjDC pjA0goz1L5e+QaDg5ozQNnI2LuyTE7I6IrX0RrSheeY5sV2HtdnAJEUcJLyYntfcwCi5xoPvt vqH4p5jBk1B4N8hOKrbrn6KT1Lx2peV5oZklOgHEjVYNJh5lJrIlUlfssS5XJEymgkyPRWmN0 1FhUPDAfJ2r4iemlpkiLDsn3OYkaw5OzQ+FRx7zkNfSErs+OGPn81/HiRAe/xSriTvFA7CEHZ t9AOVRj85k9vuDUNa8Yb7mMsytOn+Qrppyo/PR/S3qqbcgTNVPUL2Md7DosGQ8ShOPGlA= X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, GIT_PATCH_3, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Mar 2020 17:29:19 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --iX2GiQVvurZQzEDctNSWkUAQiYeUmRoVl Content-Type: multipart/mixed; boundary="TdrwLrX6iD49iPAeH2zdZ9HpkX7YSafMd"; protected-headers="v1" From: Kamil Rytarowski To: Tom Tromey Cc: gdb-patches@sourceware.org Message-ID: <5554bfd0-3d1f-6aac-93e5-b6067942485a@gmx.com> Subject: Re: [PATCH v2] Add support for "info auxv" on NetBSD References: <20200314182258.4277-1-n54@gmx.com> <20200316181710.7542-1-n54@gmx.com> <871rpnm3pn.fsf@tromey.com> In-Reply-To: <871rpnm3pn.fsf@tromey.com> --TdrwLrX6iD49iPAeH2zdZ9HpkX7YSafMd Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 20.03.2020 16:43, Tom Tromey wrote: >>>>>> "Kamil" =3D=3D Kamil Rytarowski writes: >=20 > Kamil> Register nbsd_auxv_parse() that overloads the default (Linux-sty= le) > Kamil> AUXV parsing. On NetBSD the type parameter is defined as int32_t= > Kamil> for all architectures. >=20 > Thanks for the patch. >=20 > Kamil> + > Kamil> +static int > Kamil> +nbsd_auxv_parse (struct gdbarch *gdbarch, gdb_byte **readptr, > Kamil> + gdb_byte *endptr, CORE_ADDR *typep, CORE_ADDR *valp) >=20 > In gdb a new function should always have an intro comment. This one > could just explain which gdbarch callback it implements. >=20 Done. > Kamil> +{ > Kamil> + struct type *int_type =3D builtin_type (gdbarch)->builtin_int= ; >=20 > Presumably you want builtin_in32 here? builtin_int is > architecture-dependent. Or you could just hard-code the size, with a > suitable comment. >=20 int is de facto alias for int32 on NetBSD. It cannot be shorter (there are assumptions that it is at least 32-bit) and a lot of things will break for making it longer. So it will likely stay that way forever. I prefer to keep it as 'int' to match the preexisting OpenBSD code. > Kamil> + > Kamil> +void > Kamil> +nbsd_init_abi (struct gdbarch_info info, struct gdbarch *gdbarc= h) >=20 > The intro comment here should probably say "See nbsd-tdep.h."... >=20 Done. > Kamil> +++ b/gdb/nbsd-tdep.h > Kamil> @@ -25,4 +25,6 @@ struct link_map_offsets *nbsd_lp64_solib_svr4_= fetch_link_map_offsets (void); >=20 > Kamil> int nbsd_pc_in_sigtramp (CORE_ADDR, const char *); >=20 > Kamil> +void nbsd_init_abi (struct gdbarch_info, struct gdbarch *); >=20 > ... and then there should be a descriptive comment above this line. >=20 Done. > thanks, > Tom >=20 Please see v3. --TdrwLrX6iD49iPAeH2zdZ9HpkX7YSafMd-- --iX2GiQVvurZQzEDctNSWkUAQiYeUmRoVl Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEELaxVpweEzw+lMDwuS7MI6bAudmwFAl50/QoACgkQS7MI6bAu dmwUvBAAjel1FEd6lM/CMFHIJUwls4oWl2iIILUXOVohzzrYSt/Kxkhn+wr1U4SZ rRkViGuBc4jxkJbHv2Or+04nIDb2dehxLo2K10ysA6htf/DOBbR+kyT3fuknTPfT ZqFF+JdRM8BrlxO3QnxbM3zWXbf3uxAf/i0d3rrIF+1C2xpsvObLPl0vLlrS84+l QdgVphDEhLNVBCqv9BijMREp/a0P3JKF//G1cz2iYkauRSf7LDRw+8LKjwzptS4S LIpAg1MueRpqGK6eiP4M5OV1JnEUiLlGagbUlIn05ip0kgHcZohBoOsRtAEcWqi4 WHcgDwRQ5Q4kibJufKl+zgIxweoYC4amIoJEtz9oZpGt820PMKAvwn8kizTeJDUj MWWHOE18CE2rFTJKIcMfEY2OXdWfoMXiVhY7N+Cup+d9fiRMNh4hNsJ7gzBDzrM6 MxwIWV3FbRiWeMri8FDg2iMQozSWQwgii3inGNs1e7LlHlIO2HqTyhHVwe+hL6ty GaJeKnmbXMgMxliz6Fl9in9Wc1KavoKL8uM+1uTWzIn6i/EFbbo03D2NfI31ZeYJ 9DzsnBrcWhQ5IMeJjichqss4OMlJ2m8ctQSR6lmKQwvtDUguW7XUxPAXhkihx8dV eUJ2RrRUzNIC+N4tj6NP3256up/IW68u/Q0D9QqnHA+auYUAGh0= =xOYf -----END PGP SIGNATURE----- --iX2GiQVvurZQzEDctNSWkUAQiYeUmRoVl--