From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5327 invoked by alias); 14 May 2015 10:44:31 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5316 invoked by uid 89); 14 May 2015 10:44:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 14 May 2015 10:44:30 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t4EAiSNm002653 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Thu, 14 May 2015 06:44:28 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t4EAiRTj023763; Thu, 14 May 2015 06:44:27 -0400 Message-ID: <55547C8B.5050000@redhat.com> Date: Thu, 14 May 2015 10:44:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Gary Benson , gdb-patches@sourceware.org Subject: Re: [PATCH] Move vgdb special case into remote_filesystem_is_local References: <1430146276-15606-1-git-send-email-gbenson@redhat.com> In-Reply-To: <1430146276-15606-1-git-send-email-gbenson@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-05/txt/msg00363.txt.bz2 On 04/27/2015 03:51 PM, Gary Benson wrote: > Hi all, > > Valgrind GDB (vgdb) presents itself as a remote target but works on > the local filesystem. gdb_bfd_open contained a special case to make > vgdb work with "target:" sysroots, but the implementation meant that > GDB would fall back to the local filesystem if *any* to_fileio_open > method failed with ENOSYS for *any* reason. Can you give an example target where we'd want this to behave differently? E.g,. what should happen with "target sim" ? > This commit moves the > vgdb special case to remote_filesystem_is_local to allow the fallback > to be restricted only to the specific case that remote file transfer > is unsupported. This commit also adds a warning which is displayed > the first time the fallback is used. Thanks, Pedro Alves