From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 103293 invoked by alias); 14 May 2015 10:32:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 103280 invoked by uid 89); 14 May 2015 10:32:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 14 May 2015 10:32:51 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t4EAWkPA015643 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 14 May 2015 06:32:47 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t4EAWioT007896; Thu, 14 May 2015 06:32:45 -0400 Message-ID: <555479CC.9030808@redhat.com> Date: Thu, 14 May 2015 10:32:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Joel Brobecker , gdb-patches@sourceware.org Subject: Re: [RFA] Fix gdbserver build failure on arm-android. References: <1431100919-8245-1-git-send-email-brobecker@adacore.com> In-Reply-To: <1431100919-8245-1-git-send-email-brobecker@adacore.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-05/txt/msg00362.txt.bz2 On 05/08/2015 05:01 PM, Joel Brobecker wrote: > Hello, > > The following patch... > > | proc-service, extern "C" > | > | libthread_db.so calls symbols in the client (GDB), through the > | proc-service interface. These routines must have extern "C" linkage > | so their symbol names are not mangled when GDB is built as a C++ > | program. On the GDBserver side, we were missing fallback declarations for > | all these symbols. > | > | gdb/ChangeLog: > | > | * gdb_proc_service.h: Wrap with EXTERN_C_PUSH/EXTERN_C_POP. > | > | gdb/gdbserver/ChangeLog: > | 2015-02-27 Pedro Alves > | > | * gdb_proc_service.h: Wrap with EXTERN_C_PUSH/EXTERN_C_POP. > | [!HAVE_PROC_SERVICE_H] (struct ps_prochandle): Forward declare. > | [!HAVE_PROC_SERVICE_H] (ps_pdread, ps_pdwrite, ps_ptread) > | ps_ptwrite, ps_lgetregs, ps_lsetregs, ps_lgetfpregs) > | (ps_lsetfpregs, ps_getpid) > | (ps_get_thread_area, ps_pglobal_lookup, ps_pstop, ps_pcontinue) > | (ps_lstop, ps_lcontinue, ps_lgetxregsize, ps_lgetxregs) > | (ps_lsetxregs, ps_plog): Declare. > > ... added a number of declarations which do not compile when cross- > compiling GDBserver on arm-android. The problem comes from type > prfpregset_t not being declared: > > /[...]/gdbserver/gdb_proc_service.h:98:47: > error: unknown type name 'prfpregset_t' > > After searching through the includes of the install we have, > I could not find that type being declared anywhere. So I did > the same as for prgregset_t, and created the typedef if the > type isn't declared. > > gdb/gdbserver/ChangeLog: > > * configure.ac: Add prfpregset_t BFD_HAVE_SYS_PROCFS_TYPE check. > * configure, config.in: Regenerate. > * gdb_proc_service.h [HAVE_PRFPREGSET_T] (prfpregset_t): > Declare typedef. > > OK to commit? OK. BTW, do you also trip on this one? : https://sourceware.org/ml/gdb/2015-04/msg00025.html Thanks, Pedro Alves