From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 86524 invoked by alias); 14 May 2015 09:29:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 86514 invoked by uid 89); 14 May 2015 09:29:26 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 14 May 2015 09:29:24 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t4E9TMku015207 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 14 May 2015 05:29:22 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t4E9TKF4020118; Thu, 14 May 2015 05:29:20 -0400 Message-ID: <55546AEF.9070505@redhat.com> Date: Thu, 14 May 2015 09:29:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Patrick Palka , gdb-patches@sourceware.org CC: jan.kratochvil@redhat.com Subject: Re: [PATCH] [RFC] Sync readline to version 6.3 patchlevel 8 References: <1431562331-20448-1-git-send-email-patrick@parcs.ath.cx> In-Reply-To: <1431562331-20448-1-git-send-email-patrick@parcs.ath.cx> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-05/txt/msg00358.txt.bz2 On 05/14/2015 01:12 AM, Patrick Palka wrote: > This patch syncs our upstream copy of readline to version 6.3 > patchlevel 8. > > I basically copied what was done when Jan updated to readline 6.2 in > 2011: http://sourceware.org/ml/gdb-patches/2011-05/msg00003.html > > Specifically, I: > > 1. Extracted the readline 6.3 tarball on top of readline/ > 2. Applied patches 1-8 from ftp://ftp.cwru.edu/pub/bash/readline-6.3-patches/ > 3. Omitted all the files in doc/ that were intentionally omitted before. > 4. Regenerated readline/configure and readline/examples/rlfe/configure > using autoconf 2.64. No other configure files needed regenerating. > 5. Reapplied the only local patch since the update to readline 6.2 that > has not already been applied to readline 6.3, 05942d8a1 ("Fix > executable indicator in file name completeion on Windows."). This > particular patch has been applied upstream but readline 6.3 does not > have it. Whether or not a local patch has already been applied to > readline 6.3 was determined via manual inspection. (Wasn't too bad > really.) > > The new files to make it into the tree are: > > colors.{c,h} > configure.ac > parse-colors.{c,h} > examples/hist_erasedups.c > examples/hist_purgecmd.c > > Deleted files: > > configure.in > > I've been using this patch locally for a few months now and I've > experienced only a single regression which has already been preemptively > fixed by 8900d71e3 ("Explicitly call rl_resize_terminal() in TUI's > SIGWINCH handler"). Other than that, no issues in either the CLI or the > TUI, or changes in the testsuite. Though I have only been able to test > this patch on Linux. > > Have I missed anything? What else should be done in order to sync our > copy of readline? Unlike the last sync from 5.1 to 6.2, this sync to > 6.3 is quite minor and hopefully painless. > > Because the commit is so big and so mechanical I elected to create a > branch users/ppalka/readline-6.3-update where you can view/test the > change. (I haven't looked at the branch,) but it all sounds great to me. Many thanks for doing all this. Thanks, Pedro Alves