From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17223 invoked by alias); 13 May 2015 10:47:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17117 invoked by uid 89); 13 May 2015 10:47:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 13 May 2015 10:47:11 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t4DAl58H004120 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 13 May 2015 06:47:06 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t4DAl2HG008632; Wed, 13 May 2015 06:47:04 -0400 Message-ID: <55532BA6.60803@redhat.com> Date: Wed, 13 May 2015 10:47:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Gabriel Krisman Bertazi , sergiodj@redhat.com CC: gdb-patches@sourceware.org, dje@google.com Subject: Re: [PATCH v4 0/4] catch syscall group References: <87wq0gtfxu.fsf@redhat.com> <1431304069-19647-1-git-send-email-gabriel@krisman.be> In-Reply-To: <1431304069-19647-1-git-send-email-gabriel@krisman.be> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-05/txt/msg00304.txt.bz2 On 05/11/2015 01:27 AM, Gabriel Krisman Bertazi wrote: > Thank you both for your review. > > This version has the following improvements: > > * Apply fixes suggested by Sergio in the testsuite. > * Use xsltproc to generate the xml files. > > Regarding the last change, it allowed me to identify inconsistencies in > groups for some architectures. It was a useful exercise then. ;-) Many thanks for following through with this. > The current design makes sure these > inconsistencies are fixed by centralizing the group information in a > single file. > > Also, this patch series *does not* include the generated files because > they are too big and can get in the way of code review. Reviewers must > generate those files by hand by entering the gdb/syscalls directory and > running the makefile there. Build will fail if reviewer don't do this! > Once we get this approved, I'll make sure to include the generated files > in the commit before pushing. Hopefully this will make code review > easier. Do you have a public branch somewhere with that already done? That'd make it easier for people to check the end result. You could push it to sourceware.org git nowadays, under "users/$yourname/$branch". That would be the easiest. > Also, I generated this format-patch with --find-renames. If it gets in > the way of git am/git apply, please let me know and I'll resend it. > > As usual, I'm not resending the documentation patch again because it was > already approved by Eli. Thanks, Pedro Alves