From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 50411 invoked by alias); 12 May 2015 11:47:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 49678 invoked by uid 89); 12 May 2015 11:47:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 12 May 2015 11:47:18 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id D609652; Tue, 12 May 2015 11:47:16 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t4CBlFvR022287; Tue, 12 May 2015 07:47:15 -0400 Message-ID: <5551E842.3060706@redhat.com> Date: Tue, 12 May 2015 11:47:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Patrick Palka CC: "gdb-patches@sourceware.org" Subject: Re: [PATCH] Fix PR gdb/17820 References: <1430073669-31059-1-git-send-email-patrick@parcs.ath.cx> <553E826E.70300@redhat.com> <5540B614.8020104@redhat.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-05/txt/msg00270.txt.bz2 On 05/12/2015 12:30 PM, Patrick Palka wrote: > On Wed, Apr 29, 2015 at 6:44 AM, Pedro Alves wrote: >> On 04/28/2015 02:05 AM, Patrick Palka wrote: >>>> Adding a testcase would be ideal, but I'll not make it a requirement. >>>> I think we should be able to write one making use of GDBFLAGSs. (and >>>> IWBN to test the GDBHISTSIZE/HISTSIZE environment variables too, which >>>> we can do with "set env(HISTSIZE)", etc.) >>> >>> Do you have in mind a test that creates a dummy .gdbinit file to be >>> read by GDB? Or is there another way to test this code path? >> >> It may be testable with -x or -ix on the command line too, not >> sure, gdb.base/bp-cmds-execution-x-script.exp is an example, though >> given "set history size" already behaves different today depending on when >> it is called, an alternate way to test the issue that happens to use >> the same path today may change in the future, and we may (re)introducing >> unnoticed bugs. So I think we should test that path exactly. I was >> thinking of creating a dir, put a test .gdbinit file there, and point >> HOME at that dir. We'd just skip the test on remote host testing. > > I tried this but the problem is that the testsuite seems to always > pass -nx to invocations of GDB meaning that .gdbinit files are not > read. Would you know how to work around this? > Thanks for working on this. Maybe strip -nx out of INTERNAL_GDBFLAGS temporarily. E.g.,: set saved_internal_gdbflags $INTERNAL_GDBFLAGS set INTERNAL_GDBFLAGS [string map {"-nx " ""} $INTERNAL_GDBFLAGS] ... start gdb here ... set INTERNAL_GDBFLAGS $saved_internal_gdbflags Thanks, Pedro Alves