From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1230 invoked by alias); 6 May 2015 14:38:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1211 invoked by uid 89); 6 May 2015 14:38:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 06 May 2015 14:38:28 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t46EcNTR029572 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 6 May 2015 10:38:23 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t46EcL23000957; Wed, 6 May 2015 10:38:21 -0400 Message-ID: <554A275C.80204@redhat.com> Date: Wed, 06 May 2015 14:38:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Gabriel Krisman Bertazi CC: Sergio Durigan Junior , gdb-patches@sourceware.org, dje@google.com Subject: Re: [PATCH v3 00/17] Catch syscall group References: <1430011521-24340-1-git-send-email-gabriel@krisman.be> <553F6BC0.9000905@redhat.com> <87r3r42e0v.fsf@redhat.com> <5540ABF8.4000404@redhat.com> <87k2wpt6k6.fsf@krisman.be> In-Reply-To: <87k2wpt6k6.fsf@krisman.be> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-05/txt/msg00104.txt.bz2 On 05/04/2015 03:33 AM, Gabriel Krisman Bertazi wrote: > Strace maintains static tables holding syscall names, numbers and group > information for each architecture separately. > > My script parsed those tables and mapped the syscall names in GDB's xmls > to the group information from strace. > >> If there are grouping differences between the architectures (other >> than which syscalls are wired/supported), Gabriel will have noticed >> them, but that knowledge is lost (not encoded anywhere) in the >> current form. > > I didn't see any difference in group allocation for the same syscall in > different architectures. So this shouldn't be an issue. > > Pedro made two suggestions on how to proceed: (1) keep the information > in a xml file and teach GDB about it or generate the full xml file > during the build; (2) keep the group information inside a tabular text > file and use a simple text substitution to generate the full xml during > the build. > > Personally, even though I'm not a big fan of the XML format in general, > I dislike option (2) because inserting a tabular text file now feels a > little clumsy. since we already use XML for syscalls, I think syscall > groups should be stored similarly. > > I plan to send a new version later this week (as soon as I have a break > From college) that implements Pedro's first suggestion. Now, we keep > the information inside linux-defaults.xml and have a XSL script to > performs a join of the information and generate the full XML file. Sounds great. Thanks! Thanks, Pedro Alves