From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 88898 invoked by alias); 6 May 2015 12:19:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 88880 invoked by uid 89); 6 May 2015 12:19:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 06 May 2015 12:19:24 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id C59658E6FC; Wed, 6 May 2015 12:19:22 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t46CJKk1032058; Wed, 6 May 2015 08:19:21 -0400 Message-ID: <554A06C7.6020604@redhat.com> Date: Wed, 06 May 2015 12:19:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Gary Benson , gdb-patches@sourceware.org CC: Philippe Waroquiers Subject: Re: [PATCH] Make only user-specified executable filenames sticky References: <20150505151448.GA1417@blade.nx> <1430907977-30605-1-git-send-email-gbenson@redhat.com> In-Reply-To: <1430907977-30605-1-git-send-email-gbenson@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-05/txt/msg00096.txt.bz2 On 05/06/2015 11:26 AM, Gary Benson wrote: > Hi all, > > In GDB some executable files are supplied by the user (e.g. using a > "file" command) and some are determined by GDB (e.g. while processing > an "attach" command). GDB will not attempt to determine a filename if > one has been set. This causes problems if you attach to one process > and then attach to another: GDB will not attempt to discover the main > executable on the second attach. If the two processes have different > main executable files then the symbols will now be wrong. > > This commit updates GDB to keep track of which executable filenames > were supplied by the user. When GDB might attempt to determine an > executable filename and one is already set, filenames determined by > GDB may be overridden but user-supplied filenames will not. I have a feeling this would be simpler if the flag's sense was reversed? That is, mark the exec as auto-discovered instead of marking it user-loaded. How does this interact with "symbol-file FILE" ? > Built and regtested on RHEL6.6 x86_64. > > Is this ok to commit? This fixes PR 17626 (so please add that to the ChangeLog), which is marked as duplicate of PR 16266 currently, but in a different way than 16266 suggests. https://sourceware.org/bugzilla/show_bug.cgi?id=16266 https://sourceware.org/bugzilla/show_bug.cgi?id=17626 I think this needs a NEWS entry, and probably a tweak to the manual somewhere. > --- a/gdb/exec.h > +++ b/gdb/exec.h > @@ -32,6 +32,8 @@ struct objfile; > #define exec_bfd current_program_space->ebfd > #define exec_bfd_mtime current_program_space->ebfd_mtime > #define exec_filename current_program_space->pspace_exec_filename > +#define user_supplied_exec_file_p \ > + current_program_space->pspace_user_supplied_exec_file_p Nit, but I'd suggest 'exec_file_is_user_supplied', which would fit the pattern of vars related to the exec being prefixed exec_. > > --- a/gdb/progspace.h > +++ b/gdb/progspace.h > @@ -154,6 +154,13 @@ struct program_space > It needs to be freed by xfree. It is not NULL iff EBFD is not NULL. */ > char *pspace_exec_filename; > > + /* Nonzero if pspace_exec_filename was supplied by the user, > + either at startup (on the command-line) or via a "file" > + an "add-inferior -exec" command. Zero if Sounds like an "or" is missing between the commands. Thanks, Pedro Alves