From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 90519 invoked by alias); 29 Apr 2015 19:19:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 90427 invoked by uid 89); 29 Apr 2015 19:19:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 29 Apr 2015 19:19:24 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 02259B5950; Wed, 29 Apr 2015 19:19:22 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t3TJJLma007395; Wed, 29 Apr 2015 15:19:22 -0400 Message-ID: <55412EB9.7020206@redhat.com> Date: Wed, 29 Apr 2015 20:43:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH] Cleanup num_found usage in gdb_wait_for_event References: <1430331569-17144-1-git-send-email-simon.marchi@ericsson.com> In-Reply-To: <1430331569-17144-1-git-send-email-simon.marchi@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-04/txt/msg01086.txt.bz2 On 04/29/2015 07:19 PM, Simon Marchi wrote: > Probably an artifact from the past, managing num_found in those loops is > not need. > > Regtested on Ubuntu 14.04 x64, although only with use_poll == 1. > > gdb/ChangeLog: > > * event-loop.c (gdb_wait_for_event): Cleanup uneeded usages of > num_found. Hmm, I'm not sure whether the state of poll_fds[i].revents is defined if poll returns timeout or -1/EINTR, and it seems that with this change we'll walk the poll_fds array on -1/EINTR. I was planning on sending this patch soon that touches this code, and makes use of num_found: https://github.com/palves/gdb/commit/5652cc4487a1cc5e1d5ab85b64f325292fd059f2 Now I'm curious how you ran into this. Thanks, Pedro Alves