Re: [PATCH 12/18] Implement completion limiting for sim_command_completer.

Mike Frysinger
2015-05-05T15:34:28Z

[-- Attachment #1: Type: text/plain, Size: 1037 bytes --]

On 05 May 2015 08:03, Keith Seitz wrote:
> On 04/14/2015 08:28 AM, Mike Frysinger wrote:
> > i think you want to push this down into sim/common/sim-options.c ?
> > otherwise you do all of this work only to throw away a good amount
> > of it.
>
> Eventually, yes, but not right now, if I may. I'd be more than happy
> to prepare and submit a follow-up patch for sim/ in the next week or
> two (pending acceptance of this patch series).
>
> >> It does not add any tests, since the `sim' command is highly
> >> target-dependent and unimplemented for the majority of
> >> simulators.
> >
> > erm, the majority of simulators now have testsuites. but that
> > doesn't really matter because you're updating the gdb part of the
> > API, not the sim side.
>
> Right, and I can only test it on any sim-enabled target, which I
> seldom use anymore.

that's pretty trivial to get though

$ mkdir build
$ cd build
$ ../configure --target=ft32-elf
$ make all-gdb
$ ./gdb/gdb
(gdb) target sim
(gdb) sim <tab>
-mike

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]