Re: [PATCH 12/18] Implement completion limiting for sim_command_completer.

Keith Seitz
2015-05-05T15:03:44Z

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 04/14/2015 08:28 AM, Mike Frysinger wrote:
> i think you want to push this down into sim/common/sim-options.c ?
> otherwise you do all of this work only to throw away a good amount
> of it.

Eventually, yes, but not right now, if I may. I'd be more than happy
to prepare and submit a follow-up patch for sim/ in the next week or
two (pending acceptance of this patch series).

>> It does not add any tests, since the `sim' command is highly
>> target-dependent and unimplemented for the majority of
>> simulators.
>
> erm, the majority of simulators now have testsuites. but that
> doesn't really matter because you're updating the gdb part of the
> API, not the sim side.

Right, and I can only test it on any sim-enabled target, which I
seldom use anymore.

Keith

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJVSNvBAAoJEM4/L8mVMm6zV/oQAKAy+9SyBGEXxI8FVQUyhRlL
y0Hi9ZHa5aTO+pyn0aDNkhJMSyS53F3nNLt2IEvgr/+blN+YISufpU6Tn4AX59gD
1lTzGXMKHRhdZ/uo5x+v0jM/i+05cZV72bfyvWydt+zJlU6mxV1vTwMrxIJRBgE8
ibbzvXNCCll1tkzICAe/fFVOOLgQpbSKj2PQH3f1RhwX7Xa0K0oGfxQhsh8iGVue
SGVdIS0H1EMeegcHT5IxasykqUD1IMKFVCv/pdvFJQU+2F8bqlNPMT0ODabULHLq
i6gLEicLMG4XfFjs7yOttQqezrCWk5fR78IH/fFn/xex8e58KX5F7cyVCo2qf3hC
1zJjw0+N2tpDSBXmos8s064+pFWK4dbFin36ASTpMFI7Qf/QqgQhSRYbgQ3zvXw7
pLzC4tkdCBJ/2IKsLYQZf3zr8S8wKKCG5jJkXeThbhFXMz1ZviQZ/evTkGcbLSi2
K8PBKilWYwPktL6mN1cQB0UDi7g9lvYb5v7Q+oM2boCH7LLNgKiGTrQC6sCh+CLK
emz6EPiSt0tiOaDQo1txcOL3jKEojZyoAwGuIFohtvrHmWYsDr5DAz96ZiWvTirE
IrztQ5toVTKo1rQ8MtKjwcCi0rGDOhJ/FEyvZN7aZ8NPW8IdyaJcp6Ozrjq1ZLl+
yaamOkqLO4CsBsK5rUNr
=Gh9i
-----END PGP SIGNATURE-----