From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 34215 invoked by alias); 29 Apr 2015 15:44:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 34201 invoked by uid 89); 29 Apr 2015 15:44:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 29 Apr 2015 15:44:03 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t3TFi24t008474 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 29 Apr 2015 11:44:02 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t3TFi0Yq011935; Wed, 29 Apr 2015 11:44:01 -0400 Message-ID: <5540FC3F.5050203@redhat.com> Date: Wed, 29 Apr 2015 15:44:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Jan Kratochvil , gdb-patches@sourceware.org CC: Phil Muldoon Subject: Re: [PATCH v3 2/9] compile: Distribute scope, add scope_data References: <20150411194322.29128.52477.stgit@host1.jankratochvil.net> <20150411194341.29128.87444.stgit@host1.jankratochvil.net> In-Reply-To: <20150411194341.29128.87444.stgit@host1.jankratochvil.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-04/txt/msg01072.txt.bz2 On 04/11/2015 08:43 PM, Jan Kratochvil wrote: > Provide a way to access current 'scope' during struct the do_module_cleanup "struct" ? > stage and associate more data with it. > > It should be all sub-classed but AFAIK GDB does not require C++ compiler yet. > Right, it does not. > gdb/ChangeLog > 2015-04-06 Jan Kratochvil > > * cli/cli-script.c (execute_control_command): Update > eval_compile_command caller. > * compile/compile-object-load.c (compile_object_load): Add parameters > scope and scope_data. Set them. > * compile/compile-object-load.h (struct compile_module): Add fields > scope and scope_data. > (compile_object_load): Add parameters scope and scope_data. > * compile/compile-object-run.c (struct do_module_cleanup): Add fields > scope and scope_data. > (compile_object_run): Propage the fields scope and scope_data. Propagate. > * compile/compile.c (compile_file_command, compile_code_command): > Update eval_compile_command callers. > (eval_compile_command): Add parameter scope_data. Pass it plus scope. > * compile/compile.h (eval_compile_command): Add parameter scope_data. > * defs.h (struct command_line): Add field > > extern struct compile_module *compile_object_load (const char *object_file, > - const char *source_file); > + const char *source_file, > + enum compile_i_scope_types scope, > + void *scope_data); If the line overflows, then break before the (, and indent with two spaces. See e.g., extension.h: extern const struct extension_language_defn *get_ext_lang_defn (enum extension_language lang); Otherwise OK. Thanks, Pedro Alves